diff options
| author | Stan Hu <stanhu@gmail.com> | 2015-08-26 23:36:17 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2016-01-03 15:08:44 -0800 |
| commit | 086cfc8685a6489ca032899307c77f828f515fbb (patch) | |
| tree | 0e7e750f129c6604749160a3220d889e586f3236 /CHANGELOG | |
| parent | bfb3c8d936eaafc33b00f7a1fb7644e3330ffabf (diff) | |
| download | gitlab-ce-086cfc8685a6489ca032899307c77f828f515fbb.tar.gz | |
Fix API project lookups when querying with a namespace with dots
Attempting to use the /projects/:id API by specifying :id in
"namespace/project" format would always result in a 404 if the namespace
contained a dot.
The reason? From http://guides.rubyonrails.org/routing.html#specifying-constraints:
"By default the :id parameter doesn't accept dots - this is because the dot is
used as a separator for formatted routes. If you need to use a dot within an
:id add a constraint which overrides this - for example id: /[^\/]+/ allows
anything except a slash."
Closes https://github.com/gitlabhq/gitlabhq/issues/9573
Diffstat (limited to 'CHANGELOG')
| -rw-r--r-- | CHANGELOG | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGELOG b/CHANGELOG index 2b7d5808e7e..e651aece696 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -13,6 +13,7 @@ v 8.4.0 (unreleased) - Revert back upvote and downvote button to the issue and MR pages - Swap position of Assignee and Author selector on Issuables (Zeger-Jan van de Weg) - Fix version check image in Safari + - Fix API project lookups when querying with a namespace with dots (Stan Hu) v 8.3.3 (unreleased) - Fix project transfer e-mail sending incorrect paths in e-mail notification (Stan Hu) |