diff options
| author | Robert Speicher <robert@gitlab.com> | 2016-07-29 16:54:37 +0000 |
|---|---|---|
| committer | Robert Speicher <robert@gitlab.com> | 2016-07-29 16:54:37 +0000 |
| commit | dac2e0c43d8ca3e4c593a230dcef4eb9918a4263 (patch) | |
| tree | 7e3b8967989b992d581df9a7e689f74839056997 /CHANGELOG | |
| parent | 34c083a184b98372b3b28a661d5cf41e0f2d8259 (diff) | |
| parent | 002ad215818450d2cbbc5fa065850a953dc7ada8 (diff) | |
| download | gitlab-ce-dac2e0c43d8ca3e4c593a230dcef4eb9918a4263.tar.gz | |
Merge branch 'ability-batch-issue-checking' into 'master'
Optimize checking if a user can read multiple issues
## What does this MR do?
This optimizes various parts of the code so it can more efficiently check if a user can read a list of issues.
## Are there points in the code the reviewer needs to double check?
Yes, in particular `Ability.issues_readable_by_user` should be checked to make sure it correctly allows/restricts access to issues.
## Why was this MR needed?
Currently the general approach to checking if one can read an issue is to iterate over the issues to check and call `can?(user, :read_issue, issue)` for every issue. This is not efficient as the same work has to be done for every issue.
## What are the relevant issue numbers?
* #15607
* #17463
See merge request !5370
Diffstat (limited to 'CHANGELOG')
| -rw-r--r-- | CHANGELOG | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGELOG b/CHANGELOG index 88f37735c69..2b3833d496f 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -15,6 +15,7 @@ v 8.11.0 (unreleased) - Update to gitlab_git 10.4.1 and take advantage of preserved Ref objects - Retrieve rendered HTML from cache in one request - Fix renaming repository when name contains invalid chararacters under project settings + - Optimize checking if a user has read access to a list of issues !5370 - Nokogiri's various parsing methods are now instrumented - Add a way to send an email and create an issue based on private personal token. Find the email address from issues page. !3363 - Add build event color in HipChat messages (David Eisner) |