diff options
| author | Stan Hu <stanhu@gmail.com> | 2016-05-08 19:09:33 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2016-05-09 01:17:14 -0700 |
| commit | 4be77d0b057e3b26f48fbaee947bf8f91a755f41 (patch) | |
| tree | 3377a3b9a9a05cd45827259267d7cf87eb352a27 /CHANGELOG | |
| parent | 4bc4f06512620271a8d454b966e7f5c288a68829 (diff) | |
| download | gitlab-ce-4be77d0b057e3b26f48fbaee947bf8f91a755f41.tar.gz | |
Improve multiple branch push performance by memoizing permission checking
If you attempt to push thousands of branches at once, the 60-second timeout
will occur because GitAccess checking does a lot of work to check if the
user has permission to push to a branch. This changes does two things:
1. Instead of making 1 DB query per branch push, use a memoized list of protected branches to check
2. Memoize what permissions the user has to perform on this project
On a test of 10,000 branch pushes, this prevents gitlab-shell from hitting the 60-second
timeout.
Closes #17225
Diffstat (limited to 'CHANGELOG')
| -rw-r--r-- | CHANGELOG | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGELOG b/CHANGELOG index e85d3c88b28..822fa4be565 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -4,6 +4,7 @@ v 8.8.0 (unreleased) - Assign labels and milestone to target project when moving issue. !3934 (Long Nguyen) - Project#open_branches has been cleaned up and no longer loads entire records into memory. - Escape HTML in commit titles in system note messages + - Improve multiple branch push performance by memoizing permission checking - Log to application.log when an admin starts and stops impersonating a user - Updated gitlab_git to 10.1.0 - GitAccess#protected_tag? no longer loads all tags just to check if a single one exists |