diff options
| author | Sytse Sijbrandij <sytses@gmail.com> | 2014-09-16 17:50:33 +0200 |
|---|---|---|
| committer | Sytse Sijbrandij <sytses@gmail.com> | 2014-09-16 17:50:33 +0200 |
| commit | 5a14213f06856b1b63db1712eb41099f7dd99f8d (patch) | |
| tree | 3ba967cacdbe63c49104fb60abe53e1bdffa7bb5 /CONTRIBUTING.md | |
| parent | 500a1a7bc30866b957de3ff975a60758dea8338f (diff) | |
| download | gitlab-ce-5a14213f06856b1b63db1712eb41099f7dd99f8d.tar.gz | |
Don't rebase pushed commits.
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 845be6e482b..4c80c8dbb23 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -92,13 +92,13 @@ For examples of feedback on merge requests please look at already [closed merge 1. The change is as small as possible (see the above paragraph for details) 1. Include proper tests and make all tests pass (unless it contains a test exposing a bug in existing code) -1. Can merge without problems (if not please use: `git rebase master`) +1. Initially contains a single commit (please use `git rebase -i` to squash commits) +1. Can merge without problems (if not please merge master, never rebase commits pushed to the remote server) 1. Does not break any existing functionality 1. Fixes one specific issue or implements one specific feature (do not combine things, send separate merge requests if needed) 1. Keeps the GitLab code base clean and well structured 1. Contains functionality we think other users will benefit from too 1. Doesn't add configuration options since they complicate future changes -1. Initially contains a single commit (please use `git rebase -i` to squash commits) 1. Changes after submitting the merge request should be in separate commits (no squashing). You will be asked to squash when the review is over, before merging. 1. It conforms to the following style guides |