summaryrefslogtreecommitdiff
path: root/CONTRIBUTING.md
diff options
context:
space:
mode:
authorRémy Coutable <remy@rymai.me>2017-04-28 20:03:47 +0200
committerRémy Coutable <remy@rymai.me>2017-05-03 18:25:20 +0200
commitf644b8c80a51a97e39d2f9422930efaa2b8bc334 (patch)
tree72445f343c537b607ee6576244dc7488a9b3a436 /CONTRIBUTING.md
parent0374e22a1d5e8a9555106e60804ca6bb72843443 (diff)
downloadgitlab-ce-f644b8c80a51a97e39d2f9422930efaa2b8bc334.tar.gz
Improve the Code review guidelines documentation
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'CONTRIBUTING.md')
-rw-r--r--CONTRIBUTING.md18
1 files changed, 0 insertions, 18 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index bd1e0d7f2f5..b8df8047a32 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -485,24 +485,6 @@ Please ensure that your merge request meets the contribution acceptance criteria
When having your code reviewed and when reviewing merge requests please take the
[code review guidelines](doc/development/code_review.md) into account.
-### Getting your merge request reviewed, approved, and merged
-
-There are a few rules to get your merge request accepted:
-
-1. Your merge request should only be **merged by a [maintainer][team]**.
- 1. If your merge request includes only backend changes [^1], it must be
- **approved by a [backend maintainer][team]**.
- 1. If your merge request includes only frontend changes [^1], it must be
- **approved by a [frontend maintainer][team]**.
- 1. If your merge request includes frontend and backend changes [^1], it must
- be **approved by a [frontend and a backend maintainer][team]**.
-1. To lower the amount of merge requests maintainers need to review, you can
- ask or assign any [reviewers][team] for a first review.
- 1. If you need some guidance (e.g. it's your first merge request), feel free
- to ask one of the [Merge request coaches][team].
- 1. The reviewer will assign the merge request to a maintainer once the
- reviewer is satisfied with the state of the merge request.
-
### Contribution acceptance criteria
1. The change is as small as possible