summaryrefslogtreecommitdiff
path: root/CONTRIBUTING.md
diff options
context:
space:
mode:
authorJeroen van Baarsen <jeroenvanbaarsen@gmail.com>2014-03-22 20:09:23 +0100
committerJeroen van Baarsen <jeroenvanbaarsen@gmail.com>2014-03-22 20:34:05 +0100
commit4b2c50d53f32fcd09674dc8ba0aa9719ece73d56 (patch)
tree261ab340c592e9aad5a58354f636e54d85f2348b /CONTRIBUTING.md
parent6bb474a0dc7a01108e9d2345da1c5a6e70d8aed0 (diff)
downloadgitlab-ce-4b2c50d53f32fcd09674dc8ba0aa9719ece73d56.tar.gz
Added some extra information how a good MR looks like
Diffstat (limited to 'CONTRIBUTING.md')
-rw-r--r--CONTRIBUTING.md8
1 files changed, 8 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index a6d6ec28ed9..47b04c11d24 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -77,6 +77,14 @@ Please keep the change in a single MR **as small as possible**. If you want to c
For examples of feedback on merge requests please look at already [closed merge requests](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests?assignee_id=&label_name=&milestone_id=&scope=&sort=&state=closed). Please ensure that your merge request meets the following contribution acceptance criteria.
+**Please format your merge request as follow:**
+
+1. What does this MR do?
+2. Are there points in the code the reviewer needs to double check?
+3. Why was this MR needed?
+4. What are the relevant issue numbers / [Feedback items](http://feedback.gitlab.com/)?
+5. Screenshots (If appropiate)
+
## Contribution acceptance criteria
1. The change is as small as possible (see the above paragraph for details)