diff options
author | Z.J. van de Weg <zegerjan@gitlab.com> | 2016-06-10 10:00:32 +0200 |
---|---|---|
committer | Yorick Peterse <yorickpeterse@gmail.com> | 2016-06-14 12:19:38 +0200 |
commit | f8290c2862c04f9f4cd4973824ea732ef7f6871b (patch) | |
tree | 81058b3c77005c416e7723391b793a7169cb12c9 /CONTRIBUTING.md | |
parent | 0c0ef7dfb6afb1695b62037fc0fa5aba6ce697d7 (diff) | |
download | gitlab-ce-f8290c2862c04f9f4cd4973824ea732ef7f6871b.tar.gz |
Fix timing issues on convertion migration award emoji
This commit does two things:
1. It adds logic which prevents timing issues when running the
migration. During the migration, notes can be created which _should_
be award emoji and thus migrated. To prevent these timing issues, a
lock is obtained on the table (MySQL) or on Transaction level (PG).
2. There was no down migration before as you'd probably lose some data.
Data effected is all awards on notes. These could be migrated back, as
the noteable type would just be Note, though this would litter the DB
with data which should not be there. This down migration does not yet
delete the table.
Diffstat (limited to 'CONTRIBUTING.md')
0 files changed, 0 insertions, 0 deletions