diff options
| author | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2016-08-15 15:43:04 +0000 |
|---|---|---|
| committer | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2016-08-15 15:43:04 +0000 |
| commit | 15bbab880eb9673b8120f6a34f3c145a88a58a53 (patch) | |
| tree | d22aaf09f900374eba27698369f9a645f4589eb5 /CONTRIBUTING.md | |
| parent | 06e3bb9f232329674bdc162dc8f973a19b03f3c4 (diff) | |
| download | gitlab-ce-15bbab880eb9673b8120f6a34f3c145a88a58a53.tar.gz | |
Add test requirement for new files
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fbc8e15bebf..b393e4157a9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -387,7 +387,9 @@ description area. Copy-paste it to retain the markdown format. 1. The change is as small as possible 1. Include proper tests and make all tests pass (unless it contains a test - exposing a bug in existing code) + exposing a bug in existing code). Every new file with code you created + must have a corresponging file with tests even if functionality is + already tested somewhere else. 1. If you suspect a failing CI build is unrelated to your contribution, you may try and restart the failing CI job or ask a developer to fix the aforementioned failing test |