diff options
author | Kerri Miller <kerrizor@kerrizor.com> | 2019-09-23 10:55:32 -0700 |
---|---|---|
committer | Kerri Miller <kerrizor@kerrizor.com> | 2019-10-09 10:47:45 -0700 |
commit | 8395032721f6d6cb26126a5bffcb42984a240c07 (patch) | |
tree | 875e37b4b88a3e207bd3f5a5a73cf78ce51b1daf /GITALY_SERVER_VERSION | |
parent | 7e2b1008547d8ced97a30e96ac6fbc2b7ad32a7f (diff) | |
download | gitlab-ce-8395032721f6d6cb26126a5bffcb42984a240c07.tar.gz |
Avoid #authenticate_user! in #route_not_found
This method, #route_not_found, is executed as the final fallback for
unrecognized routes (as the name might imply.) We want to avoid
`#authenticate_user!` when calling `#route_not_found`;
`#authenticate_user!` can, depending on the request format, return a 401
instead of redirecting to a login page. This opens a subtle security
exploit where anonymous users will receive a 401 response when
attempting to access a private repo, while a recognized user will
receive a 404, exposing the existence of the private, hidden repo.
Diffstat (limited to 'GITALY_SERVER_VERSION')
0 files changed, 0 insertions, 0 deletions