diff options
author | Stan Hu <stanhu@gmail.com> | 2016-09-04 04:39:10 +0000 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2016-09-04 04:39:10 +0000 |
commit | 03acf759e82231a9ca18f711ca0553eecc7d3cb8 (patch) | |
tree | 9966ccaee5b429952a014159da0a94809d17bb5e /Gemfile | |
parent | 2aaab34b67eb2a6593780eda33d501a715ef0c5f (diff) | |
parent | 49b9d8aef95dc1b0fe7ca8db9f5fab9ac35edfa5 (diff) | |
download | gitlab-ce-03acf759e82231a9ca18f711ca0553eecc7d3cb8.tar.gz |
Merge branch 'fix-spec-failures-diff-spec' into 'master'
Fix randomly failing specs in expand_collapse_diff_spec:
This MR fixes the following random failure in a spec:
```
Failure/Error: namespace.human_name + ' / ' + name
ActionView::Template::Error:
undefined method `+' for nil:NilClass
# ./app/models/project.rb:807:in `name_with_namespace'
# ./app/views/layouts/project.html.haml:1:in `_app_views_layouts_project_html_haml___2918737809244135908_70160161538920
'
# ./app/controllers/projects/commit_controller.rb:23:in `show'
# ./lib/gitlab/request_profiler/middleware.rb:15:in `call'
# ./lib/gitlab/middleware/go.rb:16:in `call'
# ./lib/gitlab/middleware/static.rb:9:in `call'
# ------------------
# --- Caused by: ---
# NoMethodError:
# undefined method `+' for nil:NilClass
# ./app/models/project.rb:807:in `name_with_namespace'
```
Capybara's `click_link` method doesn't actually wait for the page to reload.
When the `expand_all_diffs` parameter is used, we need to search for unique
elements that appear to ensure that the page has actually reloaded.
Closes #21841
See merge request !6193
Diffstat (limited to 'Gemfile')
0 files changed, 0 insertions, 0 deletions