summaryrefslogtreecommitdiff
path: root/Gemfile
diff options
context:
space:
mode:
authorSean McGivern <sean@gitlab.com>2018-11-19 10:02:21 +0000
committerSean McGivern <sean@gitlab.com>2018-11-19 10:02:21 +0000
commit07d10976d2d46067b7ac05e36fb445781a1c6f37 (patch)
tree6714d4e6edaff0bc47315f050e6998915df0b401 /Gemfile
parent7548c4d5af9198dd81adf751b41b15e9c8e5349c (diff)
parent94d518f5d68b9bcead7564b6f8d42047cdf5d23b (diff)
downloadgitlab-ce-07d10976d2d46067b7ac05e36fb445781a1c6f37.tar.gz
Merge branch '54093-the-default_value_for-gem-doesn-t-handle-actioncontroller-parameters-correctly' into 'master'46166-add-constraints-that-prevent-ci_builds-from-being-associated-with-null-pipeline-project
Replace the `default_value_for` gem with the `gitlab-default_value_with` gem which handles `ActionController::Parameters` correctly Closes #54093 See merge request gitlab-org/gitlab-ce!23114
Diffstat (limited to 'Gemfile')
-rw-r--r--Gemfile13
1 files changed, 8 insertions, 5 deletions
diff --git a/Gemfile b/Gemfile
index 65e09688c55..73c0779e8e5 100644
--- a/Gemfile
+++ b/Gemfile
@@ -4,10 +4,9 @@ def rails5?
end
gem_versions = {}
-gem_versions['activerecord_sane_schema_dumper'] = rails5? ? '1.0' : '0.2'
-gem_versions['default_value_for'] = rails5? ? '~> 3.0.5' : '~> 3.0.0'
-gem_versions['rails'] = rails5? ? '5.0.7' : '4.2.10'
-gem_versions['rails-i18n'] = rails5? ? '~> 5.1' : '~> 4.0.9'
+gem_versions['activerecord_sane_schema_dumper'] = rails5? ? '1.0' : '0.2'
+gem_versions['rails'] = rails5? ? '5.0.7' : '4.2.10'
+gem_versions['rails-i18n'] = rails5? ? '~> 5.1' : '~> 4.0.9'
# --- The end of special code for migrating to Rails 5.0 ---
source 'https://rubygems.org'
@@ -24,7 +23,11 @@ gem 'responders', '~> 2.0'
gem 'sprockets', '~> 3.7.0'
# Default values for AR models
-gem 'default_value_for', gem_versions['default_value_for']
+if rails5?
+ gem 'gitlab-default_value_for', '~> 3.1.1', require: 'default_value_for'
+else
+ gem 'default_value_for', '~> 3.0.0'
+end
# Supported DBs
gem 'mysql2', '~> 0.4.10', group: :mysql