summaryrefslogtreecommitdiff
path: root/PROCESS.md
diff options
context:
space:
mode:
authorMarin Jankovski <maxlazio@gmail.com>2019-01-31 16:41:11 +0000
committerMarin Jankovski <maxlazio@gmail.com>2019-02-12 14:57:29 +0100
commit422efcd8230e1559de0b0c5a478be03c4233a84d (patch)
treef67e6f6e58b7fbe411f5f7303f378fed72799eef /PROCESS.md
parente4c61726b43b6200f1295776fa1538fcf7cb61fb (diff)
downloadgitlab-ce-422efcd8230e1559de0b0c5a478be03c4233a84d.tar.gz
Clarify feature flag status in PROCESS.md
Diffstat (limited to 'PROCESS.md')
-rw-r--r--PROCESS.md12
1 files changed, 11 insertions, 1 deletions
diff --git a/PROCESS.md b/PROCESS.md
index 7fdac098807..66602b4070d 100644
--- a/PROCESS.md
+++ b/PROCESS.md
@@ -108,7 +108,17 @@ Merge requests that make changes hidden behind a feature flag, or remove an
existing feature flag because a feature is deemed stable, may be merged (and
picked into the stable branches) up to the 19th of the month. Such merge
requests should have the ~"feature flag" label assigned, and don't require a
-corresponding exception request to be created.
+corresponding exception request to be created.
+
+A level of common sense should be applied when deciding whether to have a feature
+behind a feature flag off or on by default.
+
+The following guideliness can be applied to help making this decision:
+
+* If the feature is not fully ready or functioning, feature flag should be disabled by default
+* If the feature is ready but there are concerns with performance or impact, feature flag should be enabled by default but feature flag
+disabled via chatops before deploy on GitLab.com environments. If the performance concern is confirmed, the final release should have the feature disabled
+* In most other cases, feature flag can be enabled by default
In order to build the final package and present the feature for self-hosted
customers, the feature flag should be removed. This should happen before the