diff options
author | Rémy Coutable <remy@rymai.me> | 2017-04-27 18:55:15 +0200 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2017-05-02 12:07:04 +0200 |
commit | ccb8e6936c9e85743e4cb42c3580b297efa889ee (patch) | |
tree | cd4b45d7978c23b3f7e0fe4842c79ed31e669168 /PROCESS.md | |
parent | 15eaca817140c315bf8ded5a5ace265020fe75f5 (diff) | |
download | gitlab-ce-ccb8e6936c9e85743e4cb42c3580b297efa889ee.tar.gz |
Document labels in CONTRIBUTING.md
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'PROCESS.md')
-rw-r--r-- | PROCESS.md | 67 |
1 files changed, 37 insertions, 30 deletions
diff --git a/PROCESS.md b/PROCESS.md index fac3c22e09f..735120a369e 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -1,35 +1,48 @@ -# GitLab Contributing Process +<!-- START doctoc generated TOC please keep comment here to allow auto update --> +<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE --> +**Table of Contents** *generated with [DocToc](https://github.com/thlorenz/doctoc)* + +- [GitLab Contributing Process](#gitlab-contributing-process) + - [Purpose of describing the contributing process](#purpose-of-describing-the-contributing-process) + - [Common actions](#common-actions) + - [Merge request coaching](#merge-request-coaching) + - [Workflow labels](#workflow-labels) + - [Assigning issues](#assigning-issues) + - [Be kind](#be-kind) + - [Feature freeze on the 7th for the release on the 22nd](#feature-freeze-on-the-7th-for-the-release-on-the-22nd) + - [Between the 1st and the 7th](#between-the-1st-and-the-7th) + - [On the 7th](#on-the-7th) + - [After the 7th](#after-the-7th) + - [Copy & paste responses](#copy-&-paste-responses) + - [Improperly formatted issue](#improperly-formatted-issue) + - [Issue report for old version](#issue-report-for-old-version) + - [Support requests and configuration questions](#support-requests-and-configuration-questions) + - [Code format](#code-format) + - [Issue fixed in newer version](#issue-fixed-in-newer-version) + - [Improperly formatted merge request](#improperly-formatted-merge-request) + - [Inactivity close of an issue](#inactivity-close-of-an-issue) + - [Inactivity close of a merge request](#inactivity-close-of-a-merge-request) + - [Accepting merge requests](#accepting-merge-requests) + - [Only accepting merge requests with green tests](#only-accepting-merge-requests-with-green-tests) + - [Closing down the issue tracker on GitHub](#closing-down-the-issue-tracker-on-github) + +<!-- END doctoc generated TOC please keep comment here to allow auto update --> + +# GitLab Core Team Contributing Process ## Purpose of describing the contributing process -Below we describe the contributing process to GitLab for two reasons. So that -contributors know what to expect from maintainers (possible responses, friendly -treatment, etc.). And so that maintainers know what to expect from contributors -(use the latest version, ensure that the issue is addressed, friendly treatment, -etc.). +Below we describe the contributing process to GitLab for two reasons: + +1. Contributors know what to expect from maintainers (possible responses, friendly + treatment, etc.) +1. Maintainers know what to expect from contributors (use the latest version, + ensure that the issue is addressed, friendly treatment, etc.). - [GitLab Inc engineers should refer to the engineering workflow document](https://about.gitlab.com/handbook/engineering/workflow/) ## Common actions -### Issue triaging - -Our issue triage policies are [described in our handbook]. You are very welcome -to help the GitLab team triage issues. We also organize [issue bash events] once -every quarter. - -The most important thing is making sure valid issues receive feedback from the -development team. Therefore the priority is mentioning developers that can help -on those issues. Please select someone with relevant experience from -[GitLab team][team]. If there is nobody mentioned with that expertise -look in the commit history for the affected files to find someone. Avoid -mentioning the lead developer, this is the person that is least likely to give a -timely response. If the involvement of the lead developer is needed the other -core team members will mention this person. - -[described in our handbook]: https://about.gitlab.com/handbook/engineering/issues/issue-triage-policies/ -[issue bash events]: https://gitlab.com/gitlab-org/gitlab-ce/issues/17815 - ### Merge request coaching Several people from the [GitLab team][team] are helping community members to get @@ -37,12 +50,6 @@ their contributions accepted by meeting our [Definition of done][done]. What you can expect from them is described at https://about.gitlab.com/jobs/merge-request-coach/. -## Workflow labels - -Labelling issues is described in the [GitLab Inc engineering workflow]. - -[GitLab Inc engineering workflow]: https://about.gitlab.com/handbook/engineering/workflow/#labelling-issues - ## Assigning issues If an issue is complex and needs the attention of a specific person, assignment is a good option but assigning issues might discourage other people from contributing to that issue. We need all the contributions we can get so this should never be discouraged. Also, an assigned person might not have time for a few weeks, so others should feel free to takeover. |