diff options
| author | Filipa Lacerda <filipa@gitlab.com> | 2017-05-10 15:52:09 +0000 |
|---|---|---|
| committer | Phil Hughes <me@iamphill.com> | 2017-05-10 15:52:09 +0000 |
| commit | d1da5624d74b6ae6ea779df1485c661fa3014fd8 (patch) | |
| tree | 36d60d37889a826bbdd020608c1bf10af09f6fe7 /app/assets/javascripts/commit | |
| parent | a8fb310cec6224b175d3b6152ad0943f06b29185 (diff) | |
| download | gitlab-ce-d1da5624d74b6ae6ea779df1485c661fa3014fd8.tar.gz | |
Tech debt: Creates vue component for loading icon
Diffstat (limited to 'app/assets/javascripts/commit')
| -rw-r--r-- | app/assets/javascripts/commit/pipelines/pipelines_table.js | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/app/assets/javascripts/commit/pipelines/pipelines_table.js b/app/assets/javascripts/commit/pipelines/pipelines_table.js index ad9c600b499..b8be0d8a301 100644 --- a/app/assets/javascripts/commit/pipelines/pipelines_table.js +++ b/app/assets/javascripts/commit/pipelines/pipelines_table.js @@ -6,6 +6,7 @@ import PipelineStore from '../../pipelines/stores/pipelines_store'; import eventHub from '../../pipelines/event_hub'; import EmptyState from '../../pipelines/components/empty_state.vue'; import ErrorState from '../../pipelines/components/error_state.vue'; +import loadingIcon from '../../vue_shared/components/loading_icon.vue'; import '../../lib/utils/common_utils'; import '../../vue_shared/vue_resource_interceptor'; import Poll from '../../lib/utils/poll'; @@ -17,8 +18,6 @@ import Poll from '../../lib/utils/poll'; * We need a store to store the received environemnts. * We need a service to communicate with the server. * - * Necessary SVG in the table are provided as props. This should be refactored - * as soon as we have Webpack and can load them directly into JS files. */ export default Vue.component('pipelines-table', { @@ -27,6 +26,7 @@ export default Vue.component('pipelines-table', { 'pipelines-table-component': PipelinesTableComponent, 'error-state': ErrorState, 'empty-state': EmptyState, + loadingIcon, }, /** @@ -151,13 +151,12 @@ export default Vue.component('pipelines-table', { template: ` <div class="content-list pipelines"> - <div - class="realtime-loading" - v-if="isLoading"> - <i - class="fa fa-spinner fa-spin" - aria-hidden="true" /> - </div> + + <loading-icon + label="Loading pipelines" + size="3" + v-if="isLoading" + /> <empty-state v-if="shouldRenderEmptyState" |