summaryrefslogtreecommitdiff
path: root/app/assets/javascripts/diff.js
diff options
context:
space:
mode:
authorBryce Johnson <bryce@gitlab.com>2017-06-12 14:43:21 -0400
committerBryce Johnson <bryce@gitlab.com>2017-06-29 12:50:45 -0400
commit81e9c2842574b10d694a8e29665c77fde7fd6ae5 (patch)
treec7fad475df58553505885b9e2de9b9543bc6d3f3 /app/assets/javascripts/diff.js
parent066a6c8ba8900f0883ee788d901d300850b1ae61 (diff)
downloadgitlab-ce-81e9c2842574b10d694a8e29665c77fde7fd6ae5.tar.gz
Render add-diff-note button with server.
This commit moves the rendering of the button back to the server, and shows/hides it using opacity rather than display. It also removes the transform applied to the button on hover (scale). Previously, both of these factors automatically triggered a reflow, which creates a performance bottleneck on pages with larger DOM size. MR: !12103
Diffstat (limited to 'app/assets/javascripts/diff.js')
-rw-r--r--app/assets/javascripts/diff.js5
1 files changed, 4 insertions, 1 deletions
diff --git a/app/assets/javascripts/diff.js b/app/assets/javascripts/diff.js
index 725ec7b9c70..1be9df19c81 100644
--- a/app/assets/javascripts/diff.js
+++ b/app/assets/javascripts/diff.js
@@ -1,6 +1,7 @@
/* eslint-disable class-methods-use-this */
import './lib/utils/url_utility';
+import FilesCommentButton from './files_comment_button';
const UNFOLD_COUNT = 20;
let isBound = false;
@@ -8,8 +9,10 @@ let isBound = false;
class Diff {
constructor() {
const $diffFile = $('.files .diff-file');
+
$diffFile.singleFileDiff();
- $diffFile.filesCommentButton();
+
+ FilesCommentButton.init($diffFile);
$diffFile.each((index, file) => new gl.ImageFile(file));