summaryrefslogtreecommitdiff
path: root/app/assets/javascripts/diff_notes/services
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2017-07-12 14:47:09 +0000
committerPhil Hughes <me@iamphill.com>2017-07-12 14:47:09 +0000
commitaaa78199c2408a05d81aa4ee3058e81bb732da16 (patch)
tree97146599b47da2f86a1701c6012f60103bad9352 /app/assets/javascripts/diff_notes/services
parentfd692d10663e5d3c7dc0de9221d6231b7fbcc464 (diff)
downloadgitlab-ce-aaa78199c2408a05d81aa4ee3058e81bb732da16.tar.gz
Update vue-resource
Diffstat (limited to 'app/assets/javascripts/diff_notes/services')
-rw-r--r--app/assets/javascripts/diff_notes/services/resolve.js26
1 files changed, 10 insertions, 16 deletions
diff --git a/app/assets/javascripts/diff_notes/services/resolve.js b/app/assets/javascripts/diff_notes/services/resolve.js
index 807ab11d292..2f063f6fe1f 100644
--- a/app/assets/javascripts/diff_notes/services/resolve.js
+++ b/app/assets/javascripts/diff_notes/services/resolve.js
@@ -1,4 +1,3 @@
-/* eslint-disable class-methods-use-this, one-var, camelcase, no-new, comma-dangle, no-param-reassign, max-len */
/* global Flash */
/* global CommentsStore */
@@ -32,27 +31,22 @@ class ResolveServiceClass {
promise = this.resolveAll(mergeRequestId, discussionId);
}
- promise.then((response) => {
- discussion.loading = false;
-
- if (response.status === 200) {
- const data = response.json();
- const resolved_by = data ? data.resolved_by : null;
+ promise
+ .then(resp => resp.json())
+ .then((data) => {
+ discussion.loading = false;
+ const resolvedBy = data ? data.resolved_by : null;
if (isResolved) {
discussion.unResolveAllNotes();
} else {
- discussion.resolveAllNotes(resolved_by);
+ discussion.resolveAllNotes(resolvedBy);
}
gl.mrWidget.checkStatus();
discussion.updateHeadline(data);
- } else {
- throw new Error('An error occurred when trying to resolve discussion.');
- }
- }).catch(() => {
- new Flash('An error occurred when trying to resolve a discussion. Please try again.');
- });
+ })
+ .catch(() => new Flash('An error occurred when trying to resolve a discussion. Please try again.'));
}
resolveAll(mergeRequestId, discussionId) {
@@ -62,7 +56,7 @@ class ResolveServiceClass {
return this.discussionResource.save({
mergeRequestId,
- discussionId
+ discussionId,
}, {});
}
@@ -73,7 +67,7 @@ class ResolveServiceClass {
return this.discussionResource.delete({
mergeRequestId,
- discussionId
+ discussionId,
}, {});
}
}