summaryrefslogtreecommitdiff
path: root/app/assets/javascripts/diffs/components
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2018-07-06 13:13:33 +0100
committerFilipa Lacerda <filipa@gitlab.com>2018-07-06 13:21:02 +0100
commitadb7f45affd71020b8b5b7f8470671c8947b6869 (patch)
treef356f8c2a50bc8a7ae959adc41ed21fbe1e15ee7 /app/assets/javascripts/diffs/components
parent9a62e72db9892708ab360c59a9f77695d9253c34 (diff)
downloadgitlab-ce-adb7f45affd71020b8b5b7f8470671c8947b6869.tar.gz
Exports getters individually.
Exports state to allow tests Adds specs for the getters that didn't have any.
Diffstat (limited to 'app/assets/javascripts/diffs/components')
-rw-r--r--app/assets/javascripts/diffs/components/inline_diff_view.vue5
-rw-r--r--app/assets/javascripts/diffs/components/parallel_diff_view.vue5
2 files changed, 2 insertions, 8 deletions
diff --git a/app/assets/javascripts/diffs/components/inline_diff_view.vue b/app/assets/javascripts/diffs/components/inline_diff_view.vue
index b884230fb63..83569346cf8 100644
--- a/app/assets/javascripts/diffs/components/inline_diff_view.vue
+++ b/app/assets/javascripts/diffs/components/inline_diff_view.vue
@@ -20,16 +20,13 @@ export default {
},
},
computed: {
- ...mapGetters(['commit']),
+ ...mapGetters(['commitId']),
normalizedDiffLines() {
return this.diffLines.map(line => (line.richText ? trimFirstCharOfLineContent(line) : line));
},
diffLinesLength() {
return this.normalizedDiffLines.length;
},
- commitId() {
- return this.commit && this.commit.id;
- },
userColorScheme() {
return window.gon.user_color_scheme;
},
diff --git a/app/assets/javascripts/diffs/components/parallel_diff_view.vue b/app/assets/javascripts/diffs/components/parallel_diff_view.vue
index 52561e197e6..89148eb5e18 100644
--- a/app/assets/javascripts/diffs/components/parallel_diff_view.vue
+++ b/app/assets/javascripts/diffs/components/parallel_diff_view.vue
@@ -21,7 +21,7 @@ export default {
},
},
computed: {
- ...mapGetters(['commit']),
+ ...mapGetters(['commitId']),
parallelDiffLines() {
return this.diffLines.map(line => {
const parallelLine = Object.assign({}, line);
@@ -44,9 +44,6 @@ export default {
diffLinesLength() {
return this.parallelDiffLines.length;
},
- commitId() {
- return this.commit && this.commit.id;
- },
userColorScheme() {
return window.gon.user_color_scheme;
},