diff options
author | André Luís <me@andr3.net> | 2018-09-08 06:37:41 +0000 |
---|---|---|
committer | Tim Zallmann <tzallmann@gitlab.com> | 2018-09-08 06:37:41 +0000 |
commit | 04c0d12d1a6cfaa54d2e5f510922b9d27c5c0a77 (patch) | |
tree | a633c79637f18b84b16f67dfca296ac0c1939185 /app/assets/javascripts/diffs/store/utils.js | |
parent | 5949f55235da76eac6e204916502843a87a33d97 (diff) | |
download | gitlab-ce-04c0d12d1a6cfaa54d2e5f510922b9d27c5c0a77.tar.gz |
Resolve "Merge requests show outdated discussions on changes tab"
Diffstat (limited to 'app/assets/javascripts/diffs/store/utils.js')
-rw-r--r-- | app/assets/javascripts/diffs/store/utils.js | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/app/assets/javascripts/diffs/store/utils.js b/app/assets/javascripts/diffs/store/utils.js index 6b1659a412c..4139a999574 100644 --- a/app/assets/javascripts/diffs/store/utils.js +++ b/app/assets/javascripts/diffs/store/utils.js @@ -217,7 +217,7 @@ export function prepareDiffData(diffData) { } } -export function getDiffRefsByLineCode(diffFiles) { +export function getDiffPositionByLineCode(diffFiles) { return diffFiles.reduce((acc, diffFile) => { const { baseSha, headSha, startSha } = diffFile.diffRefs; const { newPath, oldPath } = diffFile; @@ -237,3 +237,12 @@ export function getDiffRefsByLineCode(diffFiles) { return acc; }, {}); } + +// This method will check whether the discussion is still applicable +// to the diff line in question regarding different versions of the MR +export function isDiscussionApplicableToLine(discussion, diffPosition) { + const originalRefs = convertObjectPropsToCamelCase(discussion.original_position.formatter); + const refs = convertObjectPropsToCamelCase(discussion.position.formatter); + + return _.isEqual(refs, diffPosition) || _.isEqual(originalRefs, diffPosition); +} |