diff options
author | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2015-08-25 09:23:43 +0000 |
---|---|---|
committer | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2015-08-25 09:23:43 +0000 |
commit | c1b490d6ef995c9d0baf0133a96f13e4757214b6 (patch) | |
tree | 0167619da83fa70212f1dd6d264e852e667968c9 /app/assets/javascripts/dispatcher.js.coffee | |
parent | c06cf2bde6fcb08f476d6cf9180c545b757ce829 (diff) | |
parent | 001c8cd0ee6e70cc96727cc37eedf263b916d24b (diff) | |
download | gitlab-ce-c1b490d6ef995c9d0baf0133a96f13e4757214b6.tar.gz |
Merge branch 'handle-smtp-input-errors' into 'master'
Gracefully handle SMTP user input errors (e.g. incorrect email addresses) to prevent Sidekiq retries
### What does this MR do?
This MR gracefully handles SMTP input errors (e.g. incorrect or invalid e-mail addresses) to prevent these types of exceptions from causing Sidekiq to retry the task. If these specific exceptions occur, they will be logged, and the e-mail will be dropped from the queue.
### Why was this MR needed?
If you include an author that has a misspelled e-mail address, Sidekiq will keep sending e-mail to all the recipients even if they have already received the e-mail. The only way to recover is to clear the Sidekiq queue.
Note that other exceptions can still be thrown (e.g. `IOError`, `Net::SMTPAuthenticationError`, `Net::SMTPServerBusy`, `Net::SMTPUnknownError`, and `TimeoutError`). If the worker encounters these, Sidekiq should retry the task.
### What are the relevant issue numbers?
Closes https://github.com/gitlabhq/gitlabhq/issues/9560
See merge request !1163
Diffstat (limited to 'app/assets/javascripts/dispatcher.js.coffee')
0 files changed, 0 insertions, 0 deletions