diff options
author | Jose Ivan Vargas <jvargas@gitlab.com> | 2017-01-20 13:00:34 -0600 |
---|---|---|
committer | Jose Ivan Vargas <jvargas@gitlab.com> | 2017-01-20 13:00:34 -0600 |
commit | 2c6471dd9ab89e326411548dda5401844df4c64e (patch) | |
tree | 8580438858ffa30d99eef30a6d8d40ea43a15e3d /app/assets/javascripts/droplab | |
parent | 4af1f18639935b3a4347902f42a44e851332d5e3 (diff) | |
download | gitlab-ce-2c6471dd9ab89e326411548dda5401844df4c64e.tar.gz |
Changed the event listener target from window to document in droplab26617-search-bar-filter-dropdown-does-not-dismiss-when-sort-dropdown-is-selected
Diffstat (limited to 'app/assets/javascripts/droplab')
-rw-r--r-- | app/assets/javascripts/droplab/droplab.js | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/app/assets/javascripts/droplab/droplab.js b/app/assets/javascripts/droplab/droplab.js index ed545ec8748..6c6d650db3a 100644 --- a/app/assets/javascripts/droplab/droplab.js +++ b/app/assets/javascripts/droplab/droplab.js @@ -126,7 +126,7 @@ Object.assign(DropDown.prototype, { var item = this.items[i]; sampleItem = item; if(item.parentNode && item.parentNode.dataset.hasOwnProperty('dynamic')) { - item.parentNode.removeChild(item); + item.parentNode.removeChild(item); } } @@ -156,7 +156,7 @@ Object.assign(DropDown.prototype, { if(toAppend) { toAppend.innerHTML = newChildren.join(''); } else { - this.list.innerHTML = newChildren.join(''); + this.list.innerHTML = newChildren.join(''); } }, @@ -278,7 +278,7 @@ require('./window')(function(w){ self.hooks[i].list.hide(); } }.bind(this); - w.addEventListener('click', this.windowClickedWrapper); + document.addEventListener('click', this.windowClickedWrapper); }, removeEvents: function(){ @@ -307,7 +307,7 @@ require('./window')(function(w){ if(!list){ list = document.querySelector(hook.dataset[utils.toDataCamelCase(DATA_TRIGGER)]); } - + if(hook) { if(hook.tagName === 'A' || hook.tagName === 'BUTTON') { this.hooks.push(new HookButton(hook, list, plugins, config)); @@ -578,7 +578,7 @@ require('./window')(function(w){ var listItems = removeHighlight(list); if(currentIndex>0){ if(!listItems[currentIndex-1]){ - currentIndex = currentIndex-1; + currentIndex = currentIndex-1; } listItems[currentIndex-1].classList.add('dropdown-active'); } @@ -630,7 +630,7 @@ require('./window')(function(w){ return; } if(currentKey === 'ArrowUp') { - isUpArrow = true; + isUpArrow = true; } if(currentKey === 'ArrowDown') { isDownArrow = true; @@ -677,7 +677,7 @@ var closest = function(thisTag, stopTag) { var isDropDownParts = function(target) { if(target.tagName === 'HTML') { return false; } return ( - target.hasAttribute(DATA_TRIGGER) || + target.hasAttribute(DATA_TRIGGER) || target.hasAttribute(DATA_DROPDOWN) ); }; |