summaryrefslogtreecommitdiff
path: root/app/assets/javascripts/jobs/components/job_log.vue
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2019-06-13 13:21:44 +0100
committerFilipa Lacerda <filipa@gitlab.com>2019-06-13 13:23:39 +0100
commit12a777b2216f1887acd3dfc888e9bca775559222 (patch)
tree8b9210521d523bca0f0d8d1bc26c0c224886a04b /app/assets/javascripts/jobs/components/job_log.vue
parentcb0616fe01729cd0f2be02b16a87407a87144300 (diff)
downloadgitlab-ce-12a777b2216f1887acd3dfc888e9bca775559222.tar.gz
Adds specs and changelog - squash
Diffstat (limited to 'app/assets/javascripts/jobs/components/job_log.vue')
-rw-r--r--app/assets/javascripts/jobs/components/job_log.vue11
1 files changed, 5 insertions, 6 deletions
diff --git a/app/assets/javascripts/jobs/components/job_log.vue b/app/assets/javascripts/jobs/components/job_log.vue
index 8e4557e2b6c..28d1490259d 100644
--- a/app/assets/javascripts/jobs/components/job_log.vue
+++ b/app/assets/javascripts/jobs/components/job_log.vue
@@ -49,12 +49,12 @@ export default {
},
removeEventListener() {
this.$el
- .querySelector('.js-section-start')
- .removeEventListener('click', this.handleSectionClick);
+ .querySelectorAll('.js-section-start')
+ .forEach(el => el.removeEventListener('click', this.handleSectionClick));
},
/**
* The collapsible rows are sent in HTML from the backend
- * We need to add a onclick handler for the divs that match `.js-section-start`
+ * We need tos add a onclick handler for the divs that match `.js-section-start`
*
*/
handleCollapsibleRows() {
@@ -68,13 +68,12 @@ export default {
*/
handleSectionClick(evt) {
const clickedArrow = evt.currentTarget;
-
// toggle the arrow class
clickedArrow.classList.toggle('fa-caret-right');
clickedArrow.classList.toggle('fa-caret-down');
- const dataSection = clickedArrow.getAttribute('data-section');
- const sibilings = this.$el.querySelectorAll(`.js-s_${dataSection}:not(.js-section-header)`);
+ const { section } = clickedArrow.dataset;
+ const sibilings = this.$el.querySelectorAll(`.js-s_${section}:not(.js-section-header)`);
sibilings.forEach(row => row.classList.toggle('hidden'));
},