diff options
| author | Paul Slaughter <pslaughter@gitlab.com> | 2019-08-15 10:11:36 -0500 |
|---|---|---|
| committer | Paul Slaughter <pslaughter@gitlab.com> | 2019-08-15 10:11:36 -0500 |
| commit | e55c7a9a3572ad37a8b69cd2d3db9ab24b5ba5ab (patch) | |
| tree | 28e81b60678f7ed0b4290c479e8e7bc504313b0b /app/assets/javascripts/notes/components | |
| parent | 0495615502198e208fb9cb50d29adf26525b9b17 (diff) | |
| download | gitlab-ce-e55c7a9a3572ad37a8b69cd2d3db9ab24b5ba5ab.tar.gz | |
Add key unbinds to DiscussionKeyboardNavigatorfe-add-unbinds-to-discussion-keyboard-navigator
Also adds comment to explain why this works on the diff-tab
when it's only used in `notes-app`.
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30144#note_204066538
Diffstat (limited to 'app/assets/javascripts/notes/components')
| -rw-r--r-- | app/assets/javascripts/notes/components/discussion_keyboard_navigator.vue | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/app/assets/javascripts/notes/components/discussion_keyboard_navigator.vue b/app/assets/javascripts/notes/components/discussion_keyboard_navigator.vue index 5fc2b6ba04c..7fbfe8eebb2 100644 --- a/app/assets/javascripts/notes/components/discussion_keyboard_navigator.vue +++ b/app/assets/javascripts/notes/components/discussion_keyboard_navigator.vue @@ -25,6 +25,10 @@ export default { Mousetrap.bind('n', () => this.jumpToNextDiscussion()); Mousetrap.bind('p', () => this.jumpToPreviousDiscussion()); }, + beforeDestroy() { + Mousetrap.unbind('n'); + Mousetrap.unbind('p'); + }, methods: { ...mapActions(['expandDiscussion']), jumpToNextDiscussion() { |