[ci skip] Fix shortcuts for preview

1 files changed, 5 insertions, 11 deletions

diff --git a/app/assets/javascripts/notes/stores/getters.js b/app/assets/javascripts/notes/stores/getters.js
index 8dc24cd745e..fab2252eeb8 100644
--- a/app/assets/javascripts/notes/stores/getters.js
+++ b/app/assets/javascripts/notes/stores/getters.js
@@ -10,17 +10,10 @@ export const getIssueDataByProp = state => prop => state.issueData[prop];
 export const getUserData = state => state.userData;
 export const getUserDataByProp = state => prop => state.notesData[prop];
 
-export const notesById = (state) => {
-  const notesByIdObject = {};
-  // TODO: FILIPA: TRANSFORM INTO A REDUCE
-  state.notes.forEach((note) => {
-    note.notes.forEach((n) => {
-      notesByIdObject[n.id] = n;
-    });
-  });
-
-  return notesByIdObject;
-};
+export const notesById = state => state.notes.reduce((acc, note) => {
+  note.notes.every(n => Object.assign(acc, { [n.id]: n }));
+  return acc;
+}, {});
 
 const reverseNotes = array => array.slice(0).reverse();
 const isLastNote = (note, userId) => !note.system && note.author.id === userId;
@@ -31,6 +24,7 @@ export const getCurrentUserLastNote = state => userId => reverseNotes(state.note
     return acc;
   }, []).filter(el => el !== undefined)[0];
 
+// eslint-disable-next-line no-unused-vars
 export const getDiscussionLastNote = state => (discussion, userId) => reverseNotes(discussion.notes)
   .find(el => isLastNote(el, userId));