diff options
author | Samantha Ming <sming@gitlab.com> | 2019-06-28 07:32:03 +0000 |
---|---|---|
committer | Phil Hughes <me@iamphill.com> | 2019-06-28 07:32:03 +0000 |
commit | 4bf043435906db75fa9543db96991b8cc7171f46 (patch) | |
tree | 12d2e52d8de2ee0d174f225c0b64ea1c43c6beea /app/assets/javascripts/notes/stores | |
parent | ae68c7ea142b12fe179a4027b17d31ac6fb2649c (diff) | |
download | gitlab-ce-4bf043435906db75fa9543db96991b8cc7171f46.tar.gz |
Rearrange discussion resolve buttons & update button display
- next-discuss button is always show unless there is only 1 discussion
- regroup buttons arrangements
Diffstat (limited to 'app/assets/javascripts/notes/stores')
-rw-r--r-- | app/assets/javascripts/notes/stores/getters.js | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/app/assets/javascripts/notes/stores/getters.js b/app/assets/javascripts/notes/stores/getters.js index d7982be3e4b..8aa8f5037b3 100644 --- a/app/assets/javascripts/notes/stores/getters.js +++ b/app/assets/javascripts/notes/stores/getters.js @@ -61,15 +61,13 @@ export const unresolvedDiscussionsCount = state => state.unresolvedDiscussionsCo export const resolvableDiscussionsCount = state => state.resolvableDiscussionsCount; export const hasUnresolvedDiscussions = state => state.hasUnresolvedDiscussions; -export const showJumpToNextDiscussion = (state, getters) => (discussionId, mode = 'discussion') => { +export const showJumpToNextDiscussion = (state, getters) => (mode = 'discussion') => { const orderedDiffs = mode !== 'discussion' ? getters.unresolvedDiscussionsIdsByDiff : getters.unresolvedDiscussionsIdsByDate; - const indexOf = orderedDiffs.indexOf(discussionId); - - return indexOf !== -1 && indexOf < orderedDiffs.length - 1; + return orderedDiffs.length > 1; }; export const isDiscussionResolved = (state, getters) => discussionId => |