summaryrefslogtreecommitdiff
path: root/app/assets/javascripts/notes
diff options
context:
space:
mode:
authorPhil Hughes <me@iamphill.com>2018-09-13 10:22:35 +0100
committerPhil Hughes <me@iamphill.com>2018-09-13 10:22:35 +0100
commite12c2c77ce497eeaffa21f82890fc43fe0200af6 (patch)
treec213e801e3f95ce9f0761cc00c2dbf918100b9fd /app/assets/javascripts/notes
parent44931bd23d4e750b1bd690adaaa2fd2b40154117 (diff)
downloadgitlab-ce-e12c2c77ce497eeaffa21f82890fc43fe0200af6.tar.gz
Fixed resolved discussions not toggling expanded
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51370
Diffstat (limited to 'app/assets/javascripts/notes')
-rw-r--r--app/assets/javascripts/notes/stores/mutations.js7
1 files changed, 1 insertions, 6 deletions
diff --git a/app/assets/javascripts/notes/stores/mutations.js b/app/assets/javascripts/notes/stores/mutations.js
index 2c04bfea122..16bb54be126 100644
--- a/app/assets/javascripts/notes/stores/mutations.js
+++ b/app/assets/javascripts/notes/stores/mutations.js
@@ -214,12 +214,7 @@ export default {
[types.SET_DISCUSSION_DIFF_LINES](state, { discussionId, diffLines }) {
const discussion = utils.findNoteObjectById(state.discussions, discussionId);
- const index = state.discussions.indexOf(discussion);
- const discussionWithDiffLines = Object.assign({}, discussion, {
- truncated_diff_lines: diffLines,
- });
-
- state.discussions.splice(index, 1, discussionWithDiffLines);
+ discussion.truncated_diff_lines = diffLines;
},
};