diff options
author | Filipa Lacerda <filipa@gitlab.com> | 2017-08-30 19:47:44 +0100 |
---|---|---|
committer | Filipa Lacerda <filipa@gitlab.com> | 2017-08-30 19:47:44 +0100 |
commit | 7a0a9c23028aa487078bac6499bd86f3356c84a0 (patch) | |
tree | 1e80967c331bda9897c7bdc60b3faf4a54949cf8 /app/assets/javascripts/project_select_combo_button.js | |
parent | 0232cabca33cf07ea6ea6cebaaa63f59cbf18784 (diff) | |
download | gitlab-ce-7a0a9c23028aa487078bac6499bd86f3356c84a0.tar.gz |
Use the correct scope to avoid triggering all dropdowns
Diffstat (limited to 'app/assets/javascripts/project_select_combo_button.js')
-rw-r--r-- | app/assets/javascripts/project_select_combo_button.js | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/app/assets/javascripts/project_select_combo_button.js b/app/assets/javascripts/project_select_combo_button.js index 55e7b830716..99cea683d9a 100644 --- a/app/assets/javascripts/project_select_combo_button.js +++ b/app/assets/javascripts/project_select_combo_button.js @@ -13,14 +13,13 @@ export default class ProjectSelectComboButton { } bindEvents() { - const dropdownButton = this.projectSelectInput.siblings('.new-project-item-select-button'); - - dropdownButton.on('click', this.openDropdown); + this.projectSelectInput.siblings('.new-project-item-select-button') + .on('click', e => this.openDropdown(e)); this.newItemBtn.on('click', (e) => { if (!this.getProjectFromLocalStorage()) { e.preventDefault(); - dropdownButton.trigger('click'); + this.openDropdown(e); } }); @@ -36,8 +35,9 @@ export default class ProjectSelectComboButton { } } - openDropdown() { - $(this).siblings('.project-item-select').select2('open'); + // eslint-disable-next-line class-methods-use-this + openDropdown(event) { + $(event.currentTarget).siblings('.project-item-select').select2('open'); } selectProject() { |