summaryrefslogtreecommitdiff
path: root/app/assets/javascripts/vue_merge_request_widget
diff options
context:
space:
mode:
authorPhil Hughes <me@iamphill.com>2018-03-14 09:20:06 +0000
committerPhil Hughes <me@iamphill.com>2018-03-14 09:20:06 +0000
commit686343835f09376ada8f35f85b96e46613fdc08d (patch)
treee2237cb4e2cfad5426e612996a610f8980a75d34 /app/assets/javascripts/vue_merge_request_widget
parent123614fa650f4676a4e1b941b30587308556ac93 (diff)
downloadgitlab-ce-686343835f09376ada8f35f85b96e46613fdc08d.tar.gz
removed useless v-if
removed pointless test & changed some deployment tests to make more sense added in v-tooltip
Diffstat (limited to 'app/assets/javascripts/vue_merge_request_widget')
-rw-r--r--app/assets/javascripts/vue_merge_request_widget/components/deployment.vue7
-rw-r--r--app/assets/javascripts/vue_merge_request_widget/mr_widget_options.js4
2 files changed, 3 insertions, 8 deletions
diff --git a/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue b/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue
index dc91f8ca68c..7bef2e97349 100644
--- a/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue
+++ b/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue
@@ -119,16 +119,15 @@ export default {
</template>
<span
v-if="hasDeploymentTime"
- :data-title="deployment.deployed_at_formatted"
+ v-tooltip
+ :title="deployment.deployed_at_formatted"
class="js-deploy-time"
- data-toggle="tooltip"
- data-placement="top"
>
{{ deployTimeago }}
</span>
<loading-button
v-if="deployment.stop_url"
- container-class="btn btn-default btn-xs"
+ container-class="btn btn-default btn-xs prepend-left-default"
label="Stop environment"
:loading="isStopping"
@click="stopEnvironment"
diff --git a/app/assets/javascripts/vue_merge_request_widget/mr_widget_options.js b/app/assets/javascripts/vue_merge_request_widget/mr_widget_options.js
index 3675a2eaa85..169adfe0a1d 100644
--- a/app/assets/javascripts/vue_merge_request_widget/mr_widget_options.js
+++ b/app/assets/javascripts/vue_merge_request_widget/mr_widget_options.js
@@ -67,9 +67,6 @@ export default {
shouldRenderRelatedLinks() {
return !!this.mr.relatedLinks && !this.mr.isNothingToMergeState;
},
- shouldRenderDeployments() {
- return this.mr.deployments.length;
- },
shouldRenderSourceBranchRemovalStatus() {
return !this.mr.canRemoveSourceBranch && this.mr.shouldRemoveSourceBranch &&
(!this.mr.isNothingToMergeState && !this.mr.isMergedState);
@@ -251,7 +248,6 @@ export default {
:has-ci="mr.hasCI"
/>
<deployment
- v-if="shouldRenderDeployments"
v-for="deployment in mr.deployments"
:key="deployment.id"
:deployment="deployment"