summaryrefslogtreecommitdiff
path: root/app/assets/javascripts/vue_shared
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2018-01-09 11:58:34 +0000
committerFilipa Lacerda <filipa@gitlab.com>2018-01-09 11:58:34 +0000
commit601dc0d8b3ae08f688653df1019f2f31e020b598 (patch)
tree5a1926c52bc98725c1254950c39be6498b977748 /app/assets/javascripts/vue_shared
parent1e420c94421c569ae7d428ae2fe6e26671036180 (diff)
downloadgitlab-ce-601dc0d8b3ae08f688653df1019f2f31e020b598.tar.gz
Fix broken specs
Diffstat (limited to 'app/assets/javascripts/vue_shared')
-rw-r--r--app/assets/javascripts/vue_shared/components/loading_button.vue9
1 files changed, 2 insertions, 7 deletions
diff --git a/app/assets/javascripts/vue_shared/components/loading_button.vue b/app/assets/javascripts/vue_shared/components/loading_button.vue
index 31caa25b723..ff8c0f7c1d2 100644
--- a/app/assets/javascripts/vue_shared/components/loading_button.vue
+++ b/app/assets/javascripts/vue_shared/components/loading_button.vue
@@ -1,4 +1,5 @@
<script>
+ /* eslint-disable vue/require-default-prop */
/* This is a re-usable vue component for rendering a button
that will probably be sending off ajax requests and need
@@ -37,7 +38,6 @@
label: {
type: String,
required: false,
- default: '',
},
containerClass: {
type: String,
@@ -45,11 +45,6 @@
default: 'btn btn-align-content',
},
},
- computed: {
- hasLabel() {
- return this.label !== '';
- },
- },
methods: {
onClick(e) {
this.$emit('click', e);
@@ -77,7 +72,7 @@
</transition>
<transition name="fade">
<span
- v-if="hasLabel"
+ v-if="label"
class="js-loading-button-label"
>
{{ label }}