diff options
author | Mike Greiling <mike@pixelcog.com> | 2018-11-19 07:00:49 +0000 |
---|---|---|
committer | Mike Greiling <mike@pixelcog.com> | 2018-11-19 07:00:49 +0000 |
commit | 8dd89f03061aa646bcda5055fa96376fb9e30759 (patch) | |
tree | fbb2d8dd32bbfc6434087a4095518c74aac5ac6d /app/assets/javascripts | |
parent | 4693cebbec08d35393784afbb292315fd4d4cbee (diff) | |
parent | 59e5bad1292e21b84da0687b261eb0d2de25b3f1 (diff) | |
download | gitlab-ce-8dd89f03061aa646bcda5055fa96376fb9e30759.tar.gz |
Merge branch 'fix-not-render-emoji' into 'master'
Fix not render emoji in filter dropdown
See merge request gitlab-org/gitlab-ce!23112
Diffstat (limited to 'app/assets/javascripts')
-rw-r--r-- | app/assets/javascripts/filtered_search/dropdown_emoji.js | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/app/assets/javascripts/filtered_search/dropdown_emoji.js b/app/assets/javascripts/filtered_search/dropdown_emoji.js index af7936a92fb..d9a4d06b549 100644 --- a/app/assets/javascripts/filtered_search/dropdown_emoji.js +++ b/app/assets/javascripts/filtered_search/dropdown_emoji.js @@ -69,10 +69,13 @@ export default class DropdownEmoji extends FilteredSearchDropdown { // Replace empty gl-emoji tag to real content const dropdownItems = [...this.dropdown.querySelectorAll('.filter-dropdown-item')]; dropdownItems.forEach(dropdownItem => { - const name = dropdownItem.querySelector('.js-data-value').innerText; - const emojiTag = this.glEmojiTag(name); - const emojiElement = dropdownItem.querySelector('gl-emoji'); - emojiElement.outerHTML = emojiTag; + const valueElement = dropdownItem.querySelector('.js-data-value'); + if (valueElement !== null) { + const name = valueElement.innerText; + const emojiTag = this.glEmojiTag(name); + const emojiElement = dropdownItem.querySelector('gl-emoji'); + emojiElement.outerHTML = emojiTag; + } }); } |