diff options
author | Annabel Dunstone Gray <annabel.dunstone@gmail.com> | 2017-05-12 21:35:15 +0000 |
---|---|---|
committer | Annabel Dunstone Gray <annabel.dunstone@gmail.com> | 2017-05-12 21:35:15 +0000 |
commit | d63de44d26f1b50e62d25c6db8f3a63d98f13d45 (patch) | |
tree | 6388ced3ae488e9ba4342cad501488a6a16671f8 /app/assets/javascripts | |
parent | 09ca4c92d2c6991e0b6e58894bd381758bcfd0da (diff) | |
parent | c757000e83f57eb9e71dbf5505a3b1cd21bd8105 (diff) | |
download | gitlab-ce-d63de44d26f1b50e62d25c6db8f3a63d98f13d45.tar.gz |
Merge branch '30975-fixed-top-nav-POC' into 'master'
Add fixed positioning to top level navbar
Closes #30975
See merge request !10751
Diffstat (limited to 'app/assets/javascripts')
-rw-r--r-- | app/assets/javascripts/layout_nav.js | 10 | ||||
-rw-r--r-- | app/assets/javascripts/merge_request_tabs.js | 3 |
2 files changed, 12 insertions, 1 deletions
diff --git a/app/assets/javascripts/layout_nav.js b/app/assets/javascripts/layout_nav.js index a5f99bcdd8f..71064ccc539 100644 --- a/app/assets/javascripts/layout_nav.js +++ b/app/assets/javascripts/layout_nav.js @@ -1,4 +1,5 @@ /* eslint-disable func-names, space-before-function-paren, no-var, prefer-arrow-callback, no-unused-vars, one-var, one-var-declaration-per-line, vars-on-top, max-len */ +import _ from 'underscore'; (function() { var hideEndFade; @@ -45,4 +46,13 @@ } }); }); + + function applyScrollNavClass() { + const scrollOpacityHeight = 40; + $('.navbar-border').css('opacity', Math.min($(window).scrollTop() / scrollOpacityHeight, 1)); + } + + $(() => { + $(window).on('scroll', _.throttle(applyScrollNavClass, 100)); + }); }).call(window); diff --git a/app/assets/javascripts/merge_request_tabs.js b/app/assets/javascripts/merge_request_tabs.js index a3dff25c93b..ebb217ab13a 100644 --- a/app/assets/javascripts/merge_request_tabs.js +++ b/app/assets/javascripts/merge_request_tabs.js @@ -353,6 +353,7 @@ import BlobForkSuggestion from './blob/blob_fork_suggestion'; initAffix() { const $tabs = $('.js-tabs-affix'); + const $fixedNav = $('.navbar-gitlab'); // Screen space on small screens is usually very sparse // So we dont affix the tabs on these @@ -371,7 +372,7 @@ import BlobForkSuggestion from './blob/blob_fork_suggestion'; .affix({ offset: { top: () => ( - $diffTabs.offset().top - $tabs.height() + $diffTabs.offset().top - $tabs.height() - $fixedNav.height() ), }, }) |