rely on presense or absense of data attribute instead of coerced boolean strings

1 files changed, 6 insertions, 5 deletions

diff --git a/app/assets/javascripts/pages/projects/settings/ci_cd/show/index.js b/app/assets/javascripts/pages/projects/settings/ci_cd/show/index.js
index 152f76ff7af..37ef77c8e43 100644
--- a/app/assets/javascripts/pages/projects/settings/ci_cd/show/index.js
+++ b/app/assets/javascripts/pages/projects/settings/ci_cd/show/index.js
@@ -28,11 +28,12 @@ document.addEventListener('DOMContentLoaded', () => {
   const autoDevOpsExtraSettings = document.querySelector('.js-extra-settings');
 
   autoDevOpsSettings.addEventListener('click', event => {
-    const targetData = event.target && event.target.dataset;
-    if (targetData.hideExtraSettings === 'true') {
-      autoDevOpsExtraSettings.classList.add('hidden');
-    } else if (targetData.hideExtraSettings === 'false') {
-      autoDevOpsExtraSettings.classList.remove('hidden');
+    const target = event.target;
+    if (target.classList.contains('js-toggle-extra-settings')) {
+      autoDevOpsExtraSettings.classList.toggle(
+        'hidden',
+        !!(target.dataset && target.dataset.hideExtraSettings),
+      );
     }
   });
 });