diff options
author | Clement Ho <clemmakesapps@gmail.com> | 2017-12-19 17:48:29 +0000 |
---|---|---|
committer | Jacob Schatz <jschatz@gitlab.com> | 2017-12-19 17:48:29 +0000 |
commit | 271ebe661103b4b523ae9e50f755df9a7aeedb1d (patch) | |
tree | 7eb22c5d8f6ff5c0a87c2ab66eb2fc15dd19138c /app/assets/javascripts | |
parent | 76f3ee2feb8c2b42d625261e3fd3f6adbfcb56b4 (diff) | |
download | gitlab-ce-271ebe661103b4b523ae9e50f755df9a7aeedb1d.tar.gz |
Show inline edit button for issues
Diffstat (limited to 'app/assets/javascripts')
-rw-r--r-- | app/assets/javascripts/issue_show/components/app.vue | 2 | ||||
-rw-r--r-- | app/assets/javascripts/issue_show/components/title.vue | 2 | ||||
-rw-r--r-- | app/assets/javascripts/issue_show/index.js | 7 |
3 files changed, 2 insertions, 9 deletions
diff --git a/app/assets/javascripts/issue_show/components/app.vue b/app/assets/javascripts/issue_show/components/app.vue index 25ebe5314e0..952f49d522e 100644 --- a/app/assets/javascripts/issue_show/components/app.vue +++ b/app/assets/javascripts/issue_show/components/app.vue @@ -32,7 +32,7 @@ export default { showInlineEditButton: { type: Boolean, required: false, - default: false, + default: true, }, showDeleteButton: { type: Boolean, diff --git a/app/assets/javascripts/issue_show/components/title.vue b/app/assets/javascripts/issue_show/components/title.vue index a363d06d950..b7e6eadd440 100644 --- a/app/assets/javascripts/issue_show/components/title.vue +++ b/app/assets/javascripts/issue_show/components/title.vue @@ -79,7 +79,7 @@ v-tooltip v-if="showInlineEditButton && canUpdate" type="button" - class="btn btn-default btn-edit btn-svg" + class="btn btn-default btn-edit btn-svg js-issuable-edit" v-html="pencilIcon" title="Edit title and description" data-placement="bottom" diff --git a/app/assets/javascripts/issue_show/index.js b/app/assets/javascripts/issue_show/index.js index 7b762496ba5..75dfdedcf1b 100644 --- a/app/assets/javascripts/issue_show/index.js +++ b/app/assets/javascripts/issue_show/index.js @@ -1,5 +1,4 @@ import Vue from 'vue'; -import eventHub from './event_hub'; import issuableApp from './components/app.vue'; import '../vue_shared/vue_resource_interceptor'; @@ -7,12 +6,6 @@ document.addEventListener('DOMContentLoaded', () => { const initialDataEl = document.getElementById('js-issuable-app-initial-data'); const props = JSON.parse(initialDataEl.innerHTML.replace(/"/g, '"')); - $('.js-issuable-edit').on('click', (e) => { - e.preventDefault(); - - eventHub.$emit('open.form'); - }); - return new Vue({ el: document.getElementById('js-issuable-app'), components: { |