summaryrefslogtreecommitdiff
path: root/app/assets/javascripts
diff options
context:
space:
mode:
authorBryce Johnson <bryce@gitlab.com>2016-10-17 11:44:25 +0200
committerBryce Johnson <bryce@gitlab.com>2016-10-20 11:31:03 +0200
commit5f0b7fe429d75de2dbcfef142d2389bf99d199ec (patch)
tree4d4edc249d34698612d9c35410460dfe94f6daa6 /app/assets/javascripts
parentb5cee66612fca4f1fb9791f1c8615039d1703df3 (diff)
downloadgitlab-ce-5f0b7fe429d75de2dbcfef142d2389bf99d199ec.tar.gz
Stop injecting field errors where they won't be used.
Diffstat (limited to 'app/assets/javascripts')
-rw-r--r--app/assets/javascripts/gl_field_errors.js.es67
1 files changed, 5 insertions, 2 deletions
diff --git a/app/assets/javascripts/gl_field_errors.js.es6 b/app/assets/javascripts/gl_field_errors.js.es6
index 8657e7b4abf..8e8f9f29ab3 100644
--- a/app/assets/javascripts/gl_field_errors.js.es6
+++ b/app/assets/javascripts/gl_field_errors.js.es6
@@ -137,8 +137,11 @@
}
initValidators () {
- // select all non-hidden inputs in form
- this.state.inputs = this.form.find(':input:not([type=hidden])').toArray()
+ // register selectors here as needed
+ const validateSelectors = [':text', ':password', '[type=email]']
+ .map((selector) => `input${selector}`).join(',');
+
+ this.state.inputs = this.form.find(validateSelectors).toArray()
.filter((input) => !input.classList.contains(customValidationFlag))
.map((input) => new GlFieldError({ input, formErrors: this }));