Allow command and control click to work on MR tabs57813-merge-request-tabs-do-not-handle-ctrl-click-correctly

1 files changed, 5 insertions, 5 deletions

diff --git a/app/assets/javascripts/merge_request_tabs.js b/app/assets/javascripts/merge_request_tabs.js
index e5cf43e8289..b6868e63716 100644
--- a/app/assets/javascripts/merge_request_tabs.js
+++ b/app/assets/javascripts/merge_request_tabs.js
@@ -147,14 +147,14 @@ export default class MergeRequestTabs {
       e.stopImmediatePropagation();
       e.preventDefault();
 
-      const { action } = e.currentTarget.dataset;
+      const { action } = e.currentTarget.dataset || {};
 
-      if (action) {
-        const href = e.currentTarget.getAttribute('href');
-        this.tabShown(action, href);
-      } else if (isMetaClick(e)) {
+      if (isMetaClick(e)) {
         const targetLink = e.currentTarget.getAttribute('href');
         window.open(targetLink, '_blank');
+      } else if (action) {
+        const href = e.currentTarget.getAttribute('href');
+        this.tabShown(action, href);
       }
     }
   }