diff options
author | Clement Ho <clemmakesapps@gmail.com> | 2017-12-19 16:18:48 +0000 |
---|---|---|
committer | Phil Hughes <me@iamphill.com> | 2017-12-19 16:18:48 +0000 |
commit | 23a38eac61f44c0ee3baed68ddcf23f28c03b20d (patch) | |
tree | 4907ee71ce03bba2cd1c4a6f1fd05e14838f2d82 /app/assets/javascripts | |
parent | a9d4b2eb86be7ab77d60cfb9e3817364d5d06692 (diff) | |
download | gitlab-ce-23a38eac61f44c0ee3baed68ddcf23f28c03b20d.tar.gz |
Fix shortcut links on help page
Diffstat (limited to 'app/assets/javascripts')
-rw-r--r-- | app/assets/javascripts/docs/docs_bundle.js | 13 | ||||
-rw-r--r-- | app/assets/javascripts/shortcuts.js | 10 |
2 files changed, 21 insertions, 2 deletions
diff --git a/app/assets/javascripts/docs/docs_bundle.js b/app/assets/javascripts/docs/docs_bundle.js new file mode 100644 index 00000000000..a32bd6d0fc7 --- /dev/null +++ b/app/assets/javascripts/docs/docs_bundle.js @@ -0,0 +1,13 @@ +import Mousetrap from 'mousetrap'; + +function addMousetrapClick(el, key) { + el.addEventListener('click', () => Mousetrap.trigger(key)); +} + +function domContentLoaded() { + addMousetrapClick(document.querySelector('.js-trigger-shortcut'), '?'); + addMousetrapClick(document.querySelector('.js-trigger-search-bar'), 's'); +} + +document.addEventListener('DOMContentLoaded', domContentLoaded); + diff --git a/app/assets/javascripts/shortcuts.js b/app/assets/javascripts/shortcuts.js index 130730b1700..d2f0d7410da 100644 --- a/app/assets/javascripts/shortcuts.js +++ b/app/assets/javascripts/shortcuts.js @@ -51,7 +51,10 @@ export default class Shortcuts { } onToggleHelp(e) { - e.preventDefault(); + if (e.preventDefault) { + e.preventDefault(); + } + Shortcuts.toggleHelp(this.enabledHelp); } @@ -112,6 +115,9 @@ export default class Shortcuts { static focusSearch(e) { $('#search').focus(); - e.preventDefault(); + + if (e.preventDefault) { + e.preventDefault(); + } } } |