diff options
author | Phil Hughes <me@iamphill.com> | 2018-12-04 10:58:02 +0000 |
---|---|---|
committer | Phil Hughes <me@iamphill.com> | 2018-12-04 10:58:02 +0000 |
commit | b8ee8c27875c0fa730cdd08f00a8fcb9d845d953 (patch) | |
tree | 4155e0b9d8566c69b3ca08d3854d5ff97c74dbcf /app/assets/javascripts | |
parent | 403430968cf2a98a88d0c454501d883d6508e7e0 (diff) | |
download | gitlab-ce-b8ee8c27875c0fa730cdd08f00a8fcb9d845d953.tar.gz |
Fixed multiple diff line discussions not expanding
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53600
Diffstat (limited to 'app/assets/javascripts')
-rw-r--r-- | app/assets/javascripts/diffs/components/diff_gutter_avatars.vue | 3 | ||||
-rw-r--r-- | app/assets/javascripts/notes/stores/mutations.js | 6 |
2 files changed, 7 insertions, 2 deletions
diff --git a/app/assets/javascripts/diffs/components/diff_gutter_avatars.vue b/app/assets/javascripts/diffs/components/diff_gutter_avatars.vue index b969017a2bb..c850e0ac84f 100644 --- a/app/assets/javascripts/diffs/components/diff_gutter_avatars.vue +++ b/app/assets/javascripts/diffs/components/diff_gutter_avatars.vue @@ -56,9 +56,12 @@ export default { return `${noteData.author.name}: ${note}`; }, toggleDiscussions() { + const shouldExpand = this.discussions.some(discussion => !discussion.expanded); + this.discussions.forEach(discussion => { this.toggleDiscussion({ discussionId: discussion.id, + shouldExpand, }); }); }, diff --git a/app/assets/javascripts/notes/stores/mutations.js b/app/assets/javascripts/notes/stores/mutations.js index 667c8a97cf3..b75b7525a75 100644 --- a/app/assets/javascripts/notes/stores/mutations.js +++ b/app/assets/javascripts/notes/stores/mutations.js @@ -178,9 +178,11 @@ export default { } }, - [types.TOGGLE_DISCUSSION](state, { discussionId }) { + [types.TOGGLE_DISCUSSION](state, { discussionId, shouldExpand = null }) { const discussion = utils.findNoteObjectById(state.discussions, discussionId); - Object.assign(discussion, { expanded: !discussion.expanded }); + Object.assign(discussion, { + expanded: shouldExpand === null ? !discussion.expanded : shouldExpand, + }); }, [types.UPDATE_NOTE](state, note) { |