diff options
author | Annabel Dunstone Gray <annabel.dunstone@gmail.com> | 2016-10-05 13:57:40 +0000 |
---|---|---|
committer | Annabel Dunstone Gray <annabel.dunstone@gmail.com> | 2016-10-05 13:57:40 +0000 |
commit | 219413c5d1dbc05c4832ca372d4b06c06f2e0542 (patch) | |
tree | d4410c1e4f3bb59ac49e31a2c455b0d1059abfef /app/assets/stylesheets/pages | |
parent | c9396bc7c5b7b55fd01ec63279f5ab4223c0a184 (diff) | |
parent | 8e3e1ea0a4111fbbf8f91946f67519116fb633f3 (diff) | |
download | gitlab-ce-219413c5d1dbc05c4832ca372d4b06c06f2e0542.tar.gz |
Merge branch '22509-pipeline-tables' into 'master'
Fixes Pipeline list commit column width should be adjusted
## What does this MR do?
- Fixes some HTML problems
- Pipeline and Build tables were inside an `ul` tag
- Pipeline table had 2 `tbody` tags and no `thead`
- Adds grid classes in Pipeline table in order to be responsive: The content of the last column was being hidden but the column it self was not which results in a lot of blank space
- Adds a percentage width to the commit column in the Pipeline table.
- Removes one level of nesting in the commit column in the Pipeline table and to the Build column in the Build table.
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed?
The commit column had to much white space.
## Screenshots (if relevant)
![pipelines](/uploads/d198f07dceb498cc7ec537842cd34fff/pipelines.png)
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #22509
See merge request !6595
Diffstat (limited to 'app/assets/stylesheets/pages')
-rw-r--r-- | app/assets/stylesheets/pages/pipelines.scss | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/app/assets/stylesheets/pages/pipelines.scss b/app/assets/stylesheets/pages/pipelines.scss index b035bfc9f3c..b2662b812b7 100644 --- a/app/assets/stylesheets/pages/pipelines.scss +++ b/app/assets/stylesheets/pages/pipelines.scss @@ -22,6 +22,11 @@ .table.builds { min-width: 1200px; + + .branch-commit { + width: 33%; + } + } } @@ -77,7 +82,7 @@ } .branch-commit { - + .branch-name { font-weight: bold; max-width: 150px; |