summaryrefslogtreecommitdiff
path: root/app/assets/stylesheets/pages
diff options
context:
space:
mode:
authorAnnabel Dunstone Gray <annabel.dunstone@gmail.com>2016-10-14 21:19:25 +0000
committerAnnabel Dunstone Gray <annabel.dunstone@gmail.com>2016-10-14 21:19:25 +0000
commit2334c7f520bbe852061f2aa78f5e57895120b4e5 (patch)
tree543f80f0c20ffb82171a6260f29ec194667d41af /app/assets/stylesheets/pages
parentecd7e99a0abbceafa3559a6cd9642f8ce6cea020 (diff)
parent8751491b8db471dc661daa19bc82a9dbd58e4aae (diff)
downloadgitlab-ce-2334c7f520bbe852061f2aa78f5e57895120b4e5.tar.gz
Merge branch '23279-tabbing-over-the-login-screen-should-go-from-password-to-submit' into 'master'
Improve tabbing usability for sign in page ## What does this MR do? Rearranged the html elements so that the `sign in` button gets tabbed first before the other elements and used CSS to rearrange the visual layout. I did not use `tabindex` because it does not play well with screen readers and is not recommended from an accessibility standpoint. ## Are there points in the code the reviewer needs to double check? * Need to make sure that there aren't any side effects to my code change. `.new_user` seemed to be automatically added through `form_for()` and I'm not sure if there will be other cases where `.new_user` is used where there is no sign in page with forget your password. ## Why was this MR needed? Improves the tabbing order ## Screenshots (if relevant) None ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #23279 See merge request !6867
Diffstat (limited to 'app/assets/stylesheets/pages')
-rw-r--r--app/assets/stylesheets/pages/login.scss10
1 files changed, 10 insertions, 0 deletions
diff --git a/app/assets/stylesheets/pages/login.scss b/app/assets/stylesheets/pages/login.scss
index a5ca509163d..a08b033dff9 100644
--- a/app/assets/stylesheets/pages/login.scss
+++ b/app/assets/stylesheets/pages/login.scss
@@ -48,6 +48,16 @@
margin: 0 0 10px;
}
+ .new_user {
+ position: relative;
+ padding-bottom: 35px;
+ }
+
+ .sign-in {
+ position: absolute;
+ bottom: 0;
+ }
+
.login-footer {
margin-top: 10px;