diff options
author | Nick Thomas <nick@gitlab.com> | 2019-07-18 10:47:35 +0000 |
---|---|---|
committer | Nick Thomas <nick@gitlab.com> | 2019-07-18 10:47:35 +0000 |
commit | 3069cb25451cf9aad4840551b7286fee1c5aebc8 (patch) | |
tree | 3f7daffc2fd7adfbebe14a625293e2f005785140 /app/assets | |
parent | 69c113fc8cff7c7646bf252d32b1956b255eaf37 (diff) | |
parent | d4cc92db09a0c765556882943b7508075a0ab0e2 (diff) | |
download | gitlab-ce-3069cb25451cf9aad4840551b7286fee1c5aebc8.tar.gz |
Merge branch 'webide-commit-use-correct-parent' into 'master'
Use correct parent when committing in WebIDE
See merge request gitlab-org/gitlab-ce!29598
Diffstat (limited to 'app/assets')
-rw-r--r-- | app/assets/javascripts/ide/services/index.js | 8 | ||||
-rw-r--r-- | app/assets/javascripts/ide/stores/utils.js | 2 |
2 files changed, 2 insertions, 8 deletions
diff --git a/app/assets/javascripts/ide/services/index.js b/app/assets/javascripts/ide/services/index.js index 840761f68db..ba33b6826d6 100644 --- a/app/assets/javascripts/ide/services/index.js +++ b/app/assets/javascripts/ide/services/index.js @@ -56,13 +56,7 @@ export default { return Api.branchSingle(projectId, currentBranchId); }, commit(projectId, payload) { - // Currently the `commit` endpoint does not support `start_sha` so we - // have to make the request in the FE. This is not ideal and will be - // resolved soon. https://gitlab.com/gitlab-org/gitlab-ce/issues/59023 - const { branch, start_sha: ref } = payload; - const branchPromise = ref ? Api.createBranch(projectId, { ref, branch }) : Promise.resolve(); - - return branchPromise.then(() => Api.commitMultiple(projectId, payload)); + return Api.commitMultiple(projectId, payload); }, getFiles(projectUrl, branchId) { const url = `${projectUrl}/files/${branchId}`; diff --git a/app/assets/javascripts/ide/stores/utils.js b/app/assets/javascripts/ide/stores/utils.js index 01f78a29cf6..04470064c1f 100644 --- a/app/assets/javascripts/ide/stores/utils.js +++ b/app/assets/javascripts/ide/stores/utils.js @@ -155,7 +155,7 @@ export const createCommitPayload = ({ last_commit_id: newBranch || f.deleted || f.prevPath || f.replaces ? undefined : f.lastCommitSha, })), - start_sha: newBranch ? rootGetters.lastCommit.short_id : undefined, + start_sha: newBranch ? rootGetters.lastCommit.id : undefined, }); export const createNewMergeRequestUrl = (projectUrl, source, target) => |