diff options
| author | Tomasz Maczukin <tomasz@maczukin.pl> | 2018-02-26 17:33:43 +0100 |
|---|---|---|
| committer | Tomasz Maczukin <tomasz@maczukin.pl> | 2018-03-28 13:57:17 +0200 |
| commit | e75614e8cb391f0e499b71b261de7c8148f1b6a4 (patch) | |
| tree | dc4a1b7615fe852287c4cc399c061ab5608fd18a /app/assets | |
| parent | f18eb6dae43b8407ceb8bcbdecd6df30af2a66ac (diff) | |
| download | gitlab-ce-e75614e8cb391f0e499b71b261de7c8148f1b6a4.tar.gz | |
Add few frontend improvements
Diffstat (limited to 'app/assets')
3 files changed, 12 insertions, 2 deletions
diff --git a/app/assets/javascripts/jobs/components/sidebar_detail_row.vue b/app/assets/javascripts/jobs/components/sidebar_detail_row.vue index a24a0c5e779..dfe87d89a39 100644 --- a/app/assets/javascripts/jobs/components/sidebar_detail_row.vue +++ b/app/assets/javascripts/jobs/components/sidebar_detail_row.vue @@ -44,8 +44,12 @@ <a :href="helpUrl" target="_blank" + rel="noopener noreferrer nofollow" > - <i class="fa fa-question-circle"></i> + <i + class="fa fa-question-circle" + aria-hidden="true" + ></i> </a> </span> </p> diff --git a/app/assets/javascripts/jobs/components/sidebar_details_block.vue b/app/assets/javascripts/jobs/components/sidebar_details_block.vue index c979e11b469..ad859679a1e 100644 --- a/app/assets/javascripts/jobs/components/sidebar_details_block.vue +++ b/app/assets/javascripts/jobs/components/sidebar_details_block.vue @@ -22,6 +22,11 @@ type: Boolean, required: true, }, + runnerHelpUrl: { + type: String, + required: false, + default: '', + }, }, computed: { shouldRenderContent() { @@ -127,7 +132,7 @@ class="js-job-timeout" v-if="job.timeout" title="Timeout" - help-url="/help/ci/runners/README.html#setting-maximum-job-timeout-for-a-runner" + :help-url="runnerHelpUrl" :value="timeout" /> <detail-row diff --git a/app/assets/javascripts/jobs/job_details_bundle.js b/app/assets/javascripts/jobs/job_details_bundle.js index 85a88ae409b..656676ead91 100644 --- a/app/assets/javascripts/jobs/job_details_bundle.js +++ b/app/assets/javascripts/jobs/job_details_bundle.js @@ -51,6 +51,7 @@ export default () => { props: { isLoading: this.mediator.state.isLoading, job: this.mediator.store.state.job, + runnerHelpUrl: dataset.runnerHelpUrl, }, }); }, |