diff options
| author | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2015-10-17 18:00:02 +0000 |
|---|---|---|
| committer | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2015-10-17 18:00:02 +0000 |
| commit | 64c2bccdd90a62131c57a9c43deb34cab4e5bcbd (patch) | |
| tree | 376108b84ca2b02f28d0d341064aca0d9675ae1c /app/assets | |
| parent | 5ad3a274b3404286bb32b695c8f2b7bdd21e4953 (diff) | |
| parent | ca3ce5c26c60de421e010491cf9166f2090c8cc8 (diff) | |
| download | gitlab-ce-64c2bccdd90a62131c57a9c43deb34cab4e5bcbd.tar.gz | |
Merge branch 'fix-issue-3067' into 'master'
Fix nonatomic database update potentially causing project star counts to go negative
The `counter_cache` decrement function is called when a project star is deleted,
but there was no guarantee multiple workers would not attempt to delete the
same item simultaneously. Use an atomic update to prevent the count from going negative.
Note: I was only able to duplicate the issue on GitLab.com, but I haven't been able to replicate it anywhere else. Presumably this bug happens when the `WHERE` clause takes some time to search for the right entry and multiple requests get sent simultaneously. Need to verify whether this fix truly solves the issue.
Closes #3067
See merge request !1628
Diffstat (limited to 'app/assets')
0 files changed, 0 insertions, 0 deletions