fixes job dropdown action button error

1 files changed, 10 insertions, 6 deletions

diff --git a/app/assets/javascripts/vue_pipelines_index/stage.js.es6 b/app/assets/javascripts/vue_pipelines_index/stage.js.es6
index 8cc417a9966..cfe6ea10140 100644
--- a/app/assets/javascripts/vue_pipelines_index/stage.js.es6
+++ b/app/assets/javascripts/vue_pipelines_index/stage.js.es6
@@ -37,15 +37,19 @@
             return flash;
           });
       },
+      /**
+       * When the user right clicks or cmd/ctrl + click in the job name or action icon,
+       * the dropdown should not be closed and the link should open in another tab.
+       * If the target is a svg we stop propagation in order to prevent
+       * the default behavior of the dropdown.
+       */
       keepGraph(e) {
         const { target } = e;
+        const svgClassName = target.getAttribute('class');
+        const svgParentClassName = target.parentElement && target.parentElement.getAttribute('class');
 
-        if (target.className.indexOf('js-ci-action-icon') >= 0) return null;
-
-        if (
-          target.parentElement &&
-          (target.parentElement.className.indexOf('js-ci-action-icon') >= 0)
-        ) return null;
+        if (svgClassName && svgClassName.indexOf('js-ci-action-icon') >= 0) return null;
+        if (svgParentClassName && svgParentClassName.indexOf('js-ci-action-icon') >= 0) return null;
 
         return e.stopPropagation();
       },