diff options
| author | Douwe Maan <douwe@selenight.nl> | 2017-08-17 19:26:45 +0200 |
|---|---|---|
| committer | Douwe Maan <douwe@selenight.nl> | 2017-08-17 19:26:45 +0200 |
| commit | 5f758aff57dc54df7d92d0fb63e706d58cf1093d (patch) | |
| tree | 5eb0e5f786e37c2f8e72a6dea13fac0408da982e /app/controllers/concerns/notes_actions.rb | |
| parent | 9c22974cd14f41ed156ced0a6742dbae7412b0db (diff) | |
| download | gitlab-ce-5f758aff57dc54df7d92d0fb63e706d58cf1093d.tar.gz | |
Prefer polymorphism over `is_a?`
Diffstat (limited to 'app/controllers/concerns/notes_actions.rb')
| -rw-r--r-- | app/controllers/concerns/notes_actions.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/app/controllers/concerns/notes_actions.rb b/app/controllers/concerns/notes_actions.rb index 29142e70ed8..c568b401a2f 100644 --- a/app/controllers/concerns/notes_actions.rb +++ b/app/controllers/concerns/notes_actions.rb @@ -18,7 +18,7 @@ module NotesActions @notes = prepare_notes_for_rendering(@notes) notes_json[:notes] = - if noteable.is_a?(Issue) + if noteable.discussions_rendered_on_frontend? note_serializer.represent(@notes) else @notes.map { |note| note_json(note) } @@ -87,7 +87,7 @@ module NotesActions if note.persisted? attrs[:valid] = true - if noteable.is_a?(Issue) + if noteable.discussions_rendered_on_frontend? attrs.merge!(note_serializer.represent(note)) else attrs.merge!( |