diff options
| author | Andrew Newdigate <andrew@gitlab.com> | 2019-02-08 14:19:53 +0200 |
|---|---|---|
| committer | Andrew Newdigate <andrew@gitlab.com> | 2019-03-06 17:51:56 +0200 |
| commit | 3288e1a874ec0184f9f27f932748e51c57babf17 (patch) | |
| tree | 9f8667f5349ecfc59f3c8a6e9641cb1e32fa3d5b /app/controllers/concerns/renders_notes.rb | |
| parent | 7bbdb2a29fbc7b8c9f879c42de7063adaa8313c7 (diff) | |
| download | gitlab-ce-3288e1a874ec0184f9f27f932748e51c57babf17.tar.gz | |
Adds the Rubocop ReturnNil cop
This style change enforces `return if ...` instead of
`return nil if ...` to save maintainers a few minor review points
Diffstat (limited to 'app/controllers/concerns/renders_notes.rb')
| -rw-r--r-- | app/controllers/concerns/renders_notes.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/controllers/concerns/renders_notes.rb b/app/controllers/concerns/renders_notes.rb index ce36da6b715..18015b1de88 100644 --- a/app/controllers/concerns/renders_notes.rb +++ b/app/controllers/concerns/renders_notes.rb @@ -16,7 +16,7 @@ module RendersNotes private def preload_max_access_for_authors(notes, project) - return nil unless project + return unless project user_ids = notes.map(&:author_id) project.team.max_member_access_for_user_ids(user_ids) |