summaryrefslogtreecommitdiff
path: root/app/controllers/concerns
diff options
context:
space:
mode:
authorDouwe Maan <douwe@selenight.nl>2017-08-17 14:01:31 +0200
committerDouwe Maan <douwe@selenight.nl>2017-08-17 14:01:31 +0200
commit834f1b30d50dc3ad9d0f6ff81cef24dc6ebc375c (patch)
treee5f2e714e695d995649942111f29d4e857b33a67 /app/controllers/concerns
parent6aeb99c98bee304c5010a1173c47777eff1e04a5 (diff)
parentfe0ffcc78941bf9de98e3698e743c3cbb9846b6a (diff)
downloadgitlab-ce-834f1b30d50dc3ad9d0f6ff81cef24dc6ebc375c.tar.gz
Merge branch 'master' into issue-discussions-refactor
# Conflicts: # package.json # spec/support/features/reportable_note_shared_examples.rb
Diffstat (limited to 'app/controllers/concerns')
-rw-r--r--app/controllers/concerns/cycle_analytics_params.rb9
-rw-r--r--app/controllers/concerns/issuable_actions.rb2
2 files changed, 9 insertions, 2 deletions
diff --git a/app/controllers/concerns/cycle_analytics_params.rb b/app/controllers/concerns/cycle_analytics_params.rb
index 52e06f4945a..1ab107168c0 100644
--- a/app/controllers/concerns/cycle_analytics_params.rb
+++ b/app/controllers/concerns/cycle_analytics_params.rb
@@ -6,6 +6,13 @@ module CycleAnalyticsParams
end
def start_date(params)
- params[:start_date] == '30' ? 30.days.ago : 90.days.ago
+ case params[:start_date]
+ when '7'
+ 7.days.ago
+ when '30'
+ 30.days.ago
+ else
+ 90.days.ago
+ end
end
end
diff --git a/app/controllers/concerns/issuable_actions.rb b/app/controllers/concerns/issuable_actions.rb
index 0c3b68a7ac3..4079072a930 100644
--- a/app/controllers/concerns/issuable_actions.rb
+++ b/app/controllers/concerns/issuable_actions.rb
@@ -10,7 +10,7 @@ module IssuableActions
def destroy
issuable.destroy
destroy_method = "destroy_#{issuable.class.name.underscore}".to_sym
- TodoService.new.public_send(destroy_method, issuable, current_user)
+ TodoService.new.public_send(destroy_method, issuable, current_user) # rubocop:disable GitlabSecurity/PublicSend
name = issuable.human_class_name
flash[:notice] = "The #{name} was successfully deleted."