summaryrefslogtreecommitdiff
path: root/app/controllers/dashboard
diff options
context:
space:
mode:
authorHeinrich Lee Yu <heinrich@gitlab.com>2019-02-14 13:45:30 +0800
committerHeinrich Lee Yu <heinrich@gitlab.com>2019-02-14 14:49:18 +0800
commit0f0bf2a2cb5d6d5de94585c242bdc1378eb75bbc (patch)
treef7d750171030fe719291895d762753a0a42a14fd /app/controllers/dashboard
parentc6016ac8a8c12a736617e5250b63e0c930dda207 (diff)
downloadgitlab-ce-0f0bf2a2cb5d6d5de94585c242bdc1378eb75bbc.tar.gz
Exclude public group milestones from counts
Only count milestones in groups that the user is a member of
Diffstat (limited to 'app/controllers/dashboard')
-rw-r--r--app/controllers/dashboard/milestones_controller.rb4
1 files changed, 1 insertions, 3 deletions
diff --git a/app/controllers/dashboard/milestones_controller.rb b/app/controllers/dashboard/milestones_controller.rb
index 9484e4d30cd..912036da0ea 100644
--- a/app/controllers/dashboard/milestones_controller.rb
+++ b/app/controllers/dashboard/milestones_controller.rb
@@ -25,8 +25,6 @@ class Dashboard::MilestonesController < Dashboard::ApplicationController
private
def group_milestones
- groups = GroupsFinder.new(current_user, all_available: false).execute
-
DashboardGroupMilestone.build_collection(groups, params)
end
@@ -45,6 +43,6 @@ class Dashboard::MilestonesController < Dashboard::ApplicationController
end
def groups
- @groups ||= GroupsFinder.new(current_user, state_all: true).execute
+ @groups ||= GroupsFinder.new(current_user, all_available: false).execute
end
end