diff options
| author | Adam Niedzielski <adamsunday@gmail.com> | 2017-03-23 15:45:25 +0100 |
|---|---|---|
| committer | Adam Niedzielski <adamsunday@gmail.com> | 2017-03-23 15:49:24 +0100 |
| commit | e0d2f249b4884f9525c44119680bf804e8a7ff20 (patch) | |
| tree | 7f8598e57a29aa263a6f4d80b3ae6b2f473abffd /app/controllers/projects/deploy_keys_controller.rb | |
| parent | d576fd82333c79b3f056f26f79e85c0eceb5704b (diff) | |
| download | gitlab-ce-e0d2f249b4884f9525c44119680bf804e8a7ff20.tar.gz | |
Return 404 if deploy key cannot be found in Projects::DeployKeysController#disable
Closes #29633
Diffstat (limited to 'app/controllers/projects/deploy_keys_controller.rb')
| -rw-r--r-- | app/controllers/projects/deploy_keys_controller.rb | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/app/controllers/projects/deploy_keys_controller.rb b/app/controllers/projects/deploy_keys_controller.rb index 1502b734f37..d0c44e297e3 100644 --- a/app/controllers/projects/deploy_keys_controller.rb +++ b/app/controllers/projects/deploy_keys_controller.rb @@ -31,8 +31,10 @@ class Projects::DeployKeysController < Projects::ApplicationController end def disable - @project.deploy_keys_projects.find_by(deploy_key_id: params[:id]).destroy + deploy_key_project = @project.deploy_keys_projects.find_by(deploy_key_id: params[:id]) + return render_404 unless deploy_key_project + deploy_key_project.destroy! redirect_to_repository_settings(@project) end |