summaryrefslogtreecommitdiff
path: root/app/controllers/snippets
diff options
context:
space:
mode:
authorHeinrich Lee Yu <heinrich@gitlab.com>2019-02-14 20:22:51 +0800
committerHeinrich Lee Yu <heinrich@gitlab.com>2019-02-23 09:38:58 +0800
commitd03dee26b9d15440ba3d52d319b11474176143c4 (patch)
tree5e4359ed56bdd13da6b00d56ed55930626f1d2d8 /app/controllers/snippets
parent48d31abc97528a36614b545f0b61fa14053ce4a8 (diff)
downloadgitlab-ce-d03dee26b9d15440ba3d52d319b11474176143c4.tar.gz
Refactor params for notes_actions
Removes unneeded params from permitted list This also fixes commenting on commits with a hash starting with a large number
Diffstat (limited to 'app/controllers/snippets')
-rw-r--r--app/controllers/snippets/notes_controller.rb4
1 files changed, 0 insertions, 4 deletions
diff --git a/app/controllers/snippets/notes_controller.rb b/app/controllers/snippets/notes_controller.rb
index 091bcb1253d..eee14b0faf4 100644
--- a/app/controllers/snippets/notes_controller.rb
+++ b/app/controllers/snippets/notes_controller.rb
@@ -26,10 +26,6 @@ class Snippets::NotesController < ApplicationController
# rubocop: enable CodeReuse/ActiveRecord
alias_method :noteable, :snippet
- def note_params
- super.merge(noteable_id: params[:snippet_id])
- end
-
def finder_params
params.merge(last_fetched_at: last_fetched_at, target_id: snippet.id, target_type: 'personal_snippet')
end