diff options
author | James Lopez <james@jameslopez.es> | 2016-11-16 12:01:10 +0100 |
---|---|---|
committer | James Lopez <james@jameslopez.es> | 2016-11-17 08:22:59 +0100 |
commit | cf2dcf043c0054785bc0258ab6393104499b8d70 (patch) | |
tree | 1502646c438eb383a82f73d5a62f2b19b38d954c /app/controllers | |
parent | cbc9f0cd1aa9f379952b6e4d3ad6df9971f9092a (diff) | |
download | gitlab-ce-cf2dcf043c0054785bc0258ab6393104499b8d70.tar.gz |
Refactor all query config stuff into separate classes and added specs
Diffstat (limited to 'app/controllers')
-rw-r--r-- | app/controllers/projects/cycle_analytics/events_controller.rb | 124 |
1 files changed, 62 insertions, 62 deletions
diff --git a/app/controllers/projects/cycle_analytics/events_controller.rb b/app/controllers/projects/cycle_analytics/events_controller.rb index 961183f44c3..2b4db0fd4aa 100644 --- a/app/controllers/projects/cycle_analytics/events_controller.rb +++ b/app/controllers/projects/cycle_analytics/events_controller.rb @@ -1,67 +1,67 @@ module Projects module CycleAnalytics -class EventsController < Projects::ApplicationController - include CycleAnalyticsParams - - before_action :authorize_read_cycle_analytics! - before_action :authorize_builds!, only: [:test, :staging] - - def issue - render_events(events.issue_events) - end - - def plan - render_events(events.plan_events) - end - - def code - render_events(events.code_events) - end - - def test - @options = { from: start_date(events_params), branch: events_params[:branch_name] } - - render_events(events.test_events) - end - - def review - render_events(events.review_events) - end - - def staging - render_events(events.staging_events) - end - - def production - render_events(events.production_events) - end - - private - - def render_events(events_list) - respond_to do |format| - format.html - format.json { render json: { events: events_list } } + class EventsController < Projects::ApplicationController + include CycleAnalyticsParams + + before_action :authorize_read_cycle_analytics! + before_action :authorize_builds!, only: [:test, :staging] + + def issue + render_events(events.issue_events) + end + + def plan + render_events(events.plan_events) + end + + def code + render_events(events.code_events) + end + + def test + @options = { from: start_date(events_params), branch: events_params[:branch_name] } + + render_events(events.test_events) + end + + def review + render_events(events.review_events) + end + + def staging + render_events(events.staging_events) + end + + def production + render_events(events.production_events) + end + + private + + def render_events(events_list) + respond_to do |format| + format.html + format.json { render json: { events: events_list } } + end + end + + def events + @events ||= Gitlab::CycleAnalytics::Events.new(project: project, options: options) + end + + def options + @options ||= { from: start_date(events_params) } + end + + def events_params + return {} unless params[:events].present? + + params[:events].slice(:start_date, :branch_name) + end + + def authorize_builds! + return access_denied! unless current_user.can?(:read_build, project) + end end end - - def events - @events ||= Gitlab::CycleAnalytics::Events.new(project: project, options: options) - end - - def options - @options ||= { from: start_date(events_params) } - end - - def events_params - return {} unless params[:events].present? - - params[:events].slice(:start_date, :branch_name) - end - - def authorize_builds! - return access_denied! unless current_user.can?(:read_build, project) - end -end - end end |