summaryrefslogtreecommitdiff
path: root/app/controllers
diff options
context:
space:
mode:
authorAhmad Sherif <me@ahmadsherif.com>2018-02-28 17:56:00 +0100
committerAhmad Sherif <me@ahmadsherif.com>2018-03-01 18:31:31 +0100
commit03f3350f3f679122ce4ceacfc840db6e77763dea (patch)
tree7569d6f1aef894ef13acf262b87b4419f6270d8d /app/controllers
parent1c2b633b1f4817ca4a3184fb7ff73b1d6b2bbb8f (diff)
downloadgitlab-ce-03f3350f3f679122ce4ceacfc840db6e77763dea.tar.gz
Fetch commit signatures from Gitaly in batchesfeature/fetch-commit-signs-from-gitaly-in-batch
Closes gitaly#1046
Diffstat (limited to 'app/controllers')
-rw-r--r--app/controllers/projects/commits_controller.rb44
1 files changed, 19 insertions, 25 deletions
diff --git a/app/controllers/projects/commits_controller.rb b/app/controllers/projects/commits_controller.rb
index 1d910e461b1..7b7cb52d7ed 100644
--- a/app/controllers/projects/commits_controller.rb
+++ b/app/controllers/projects/commits_controller.rb
@@ -14,37 +14,31 @@ class Projects::CommitsController < Projects::ApplicationController
@merge_request = MergeRequestsFinder.new(current_user, project_id: @project.id).execute.opened
.find_by(source_project: @project, source_branch: @ref, target_branch: @repository.root_ref)
- # https://gitlab.com/gitlab-org/gitaly/issues/931
- Gitlab::GitalyClient.allow_n_plus_1_calls do
- respond_to do |format|
- format.html
- format.atom { render layout: 'xml.atom' }
+ respond_to do |format|
+ format.html
+ format.atom { render layout: 'xml.atom' }
- format.json do
- pager_json(
- 'projects/commits/_commits',
- @commits.size,
- project: @project,
- ref: @ref)
- end
+ format.json do
+ pager_json(
+ 'projects/commits/_commits',
+ @commits.size,
+ project: @project,
+ ref: @ref)
end
end
end
def signatures
- # https://gitlab.com/gitlab-org/gitaly/issues/931
- Gitlab::GitalyClient.allow_n_plus_1_calls do
- respond_to do |format|
- format.json do
- render json: {
- signatures: @commits.select(&:has_signature?).map do |commit|
- {
- commit_sha: commit.sha,
- html: view_to_html_string('projects/commit/_signature', signature: commit.signature)
- }
- end
- }
- end
+ respond_to do |format|
+ format.json do
+ render json: {
+ signatures: @commits.select(&:has_signature?).map do |commit|
+ {
+ commit_sha: commit.sha,
+ html: view_to_html_string('projects/commit/_signature', signature: commit.signature)
+ }
+ end
+ }
end
end
end